[U-Boot] [PATCH] tools: xilinx: Fix zynq/zynqmp image recognition

[Michal Simek]

On 16.3.2018 11:33, Alexander Graf wrote:
> 
> 
>> Am 16.03.2018 um 11:22 schrieb Michal Simek <michal.simek at xilinx.com>:
>>
>>> On 15.3.2018 22:54, Alexander Graf wrote:
>>>
>>>
>>>> On 14.03.18 11:14, Michal Simek wrote:
>>>> There is an issue to recognize zynq or zynqmp image because header
>>>> checking is just the same. That's why zynqmp images are recognized as
>>>> zynq one.
>>>> Check unused fields which are initialized to zero in zynq format
>>>> (__reserved1 0x38 and __reserved2 0x44) which are initialized for
>>>> zynqmp. This should ensure that images are properly recognized by:
>>>> ./tools/mkimage -l spl/boot.bin
>>>>
>>>> Also show image type as ZynqMP instead of Zynq which is confusing
>>>> and parse a53 64bit cpu select option in image_attributes field to make
>>>> sure that this is ZynqMP image.
>>>
>>> What if the target is on R5?
>>
>> I expect you know the answer. I have ported u-boot on R5 which could use
>> this feature but mkimage is not prepared for that.
>>
>> I am happy to remove this zynqmp detection code because it should be
>> enough what it is done for zynq. Just let me know if you want to remove it.
> 
> Yes, please :).

v2 sent with this.

> 
>>
>>>
>>>> Reported-by: Alexander Graf <agraf at suse.de>
>>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>>
>>> Tested-by: Alexander Graf <agraf at suse.de>
>>
>> It is question how exactly you want to use mkimage tools. If for u-boot
>> generated images or for generic boot.bin generated by bootgen.
> 
> I think it makes sense to converge the two mechanisms. I want to be able to swap individual components between the two; use fsbl with mkimage and spl with bootgen. I don‘t think we‘re very far from that.

You can do it now without any issue. Bootgen expects files with elf
suffix which is not needed for mkimage.

> 
> Alternatively Xilinx could open source bootgen and we could just use that always ;).

Not my decision.

Thanks,
Michal