[U-Boot] [PATCH v2] davinci: Enable DDR_INIT for DA8XX

David Lechner david at lechnology.com
Fri Mar 16 15:14:56 UTC 2018


On 03/16/2018 03:52 AM, Lokesh Vutla wrote:
> Commit 6aa4ad8e3820 ("Convert CONFIG_SOC_DA8XX et al to Kconfig")
> converted SOC_DA8XX to Kconfig but missed enabling DDR_INIT for
> SOC_DA8XX, which broke OMAPL138 to boot.
> 
> Commit 2e87980580d0 ("davinci: Fix omapl138_lcdk builds") disabled
> DDR_INIT for all DA850 SoCs. This failed all DA850 boards to boot
> as ddr is not being initialized.
> 
> Enable SYS_DA850_DDR_INIT for DA8XX so that all DA850 and OMAPL138
> will have ddr initialized
> 
> Fixes: 2e87980580d0 ("davinci: Fix omapl138_lcdk builds")
> Fixes: 6aa4ad8e3820 ("Convert CONFIG_SOC_DA8XX et al to Kconfig")
> Reported-by: Sekhar Nori <nsekhar at ti.com>
> Tested-by: Sekhar Nori <nsekhar at ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla at ti.com>
> ---
> Changes since v1:
> - Fixed the typo DRA8XX to DA8XX
> 
>   arch/arm/mach-davinci/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
> index 30752839a3..5e7baba3fe 100644
> --- a/arch/arm/mach-davinci/Kconfig
> +++ b/arch/arm/mach-davinci/Kconfig
> @@ -58,6 +58,7 @@ config SOC_DA850
>   config SOC_DA8XX
>   	bool
>   	select SYS_DA850_PLL_INIT if SUPPORT_SPL || DA850_LOWLEVEL
> +	select SYS_DA850_DDR_INIT if SUPPORT_SPL || DA850_LOWLEVEL
>   
>   config MACH_DAVINCI_DA850_EVM
>   	bool
> 

Shouldn't

	select SYS_DA850_DDR_INIT if SUPPORT_SPL || DA850_LOWLEVEL

be removed from config SOC_DA850?

It seems redundant to have it in both places since SOC_DA850
selects SOC_DA8XX.


More information about the U-Boot mailing list