[U-Boot] [PATCH] lan7xxx: Require phylib

Joe Hershberger joe.hershberger at ni.com
Fri Mar 16 17:29:00 UTC 2018


On Thu, Mar 15, 2018 at 10:16 PM, Tuomas Tynkkynen <tuomas at tuxera.com> wrote:
> Hi,
>
> On Thu, 15 Mar 2018 15:10:20 +0100
> Alexander Graf <agraf at suse.de> wrote:
>
>> The lan75xx and lan78xx drivers need to drive their phy via the generic
>> phylib framework. Let's reflect that dependency in Kconfig, so that we
>> don't get build errors when phylib does not get selected.
>>
>> Signed-off-by: Alexander Graf <agraf at suse.de>
>> ---
>>  drivers/usb/eth/Kconfig | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/eth/Kconfig b/drivers/usb/eth/Kconfig
>> index 496a6d1933..2f6bfa8e71 100644
>> --- a/drivers/usb/eth/Kconfig
>> +++ b/drivers/usb/eth/Kconfig
>> @@ -23,6 +23,7 @@ config USB_ETHER_ASIX88179
>>  config USB_ETHER_LAN75XX
>>       bool "Microchip LAN75XX support"
>>       depends on USB_HOST_ETHER
>> +     depends on PHYLIB
>
> 'select PHYLIB' seems more appropriate here (and there are already 17
> drivers selecting it and none using 'depends on'.)

Yeah, good point. Please change this.

Thanks,
-Joe


More information about the U-Boot mailing list