[U-Boot] [PATCH] watchdog: bcm6345: convert to use live dt

[Daniel Schwierzeck]

On 17.03.2018 12:23, Álvaro Fernández Rojas wrote:
> Signed-off-by: Álvaro Fernández Rojas <noltari at gmail.com>
> ---
>  drivers/watchdog/bcm6345_wdt.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/bcm6345_wdt.c b/drivers/watchdog/bcm6345_wdt.c
> index 3ef7d438a6..90b33aadf1 100644
> --- a/drivers/watchdog/bcm6345_wdt.c
> +++ b/drivers/watchdog/bcm6345_wdt.c
> @@ -87,13 +87,12 @@ static int bcm6345_wdt_probe(struct udevice *dev)
>  {
>  	struct bcm6345_wdt_priv *priv = dev_get_priv(dev);
>  	fdt_addr_t addr;
> -	fdt_size_t size;
>  
> -	addr = devfdt_get_addr_size_index(dev, 0, &size);
> +	addr = dev_read_addr(dev);
>  	if (addr == FDT_ADDR_T_NONE)
>  		return -EINVAL;
>  
> -	priv->regs = ioremap(addr, size);
> +	priv->regs = ioremap(addr, 0);

as this pattern is repeated in each driver which have to do such
remapping on archs like MIPS, I suggest to add generic wrapper functions
for this like:

void *dev_read_addr_and_remap_index(struct udevice *dev, int index)

void *dev_read_addr_and_remap(struct udevice *dev)

>  
>  	bcm6345_wdt_stop(dev);
>  
> 

-- 
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180317/86c0777d/attachment.sig>