[U-Boot] [PATCH 1/3] phy: add support for bcm6348 usbh phy

[Álvaro Fernández Rojas]

Hi Daniel,


El 17/03/2018 a las 20:30, Daniel Schwierzeck escribió:
>
> On 04.02.2018 11:18, Álvaro Fernández Rojas wrote:
>> Signed-off-by: Álvaro Fernández Rojas <noltari at gmail.com>
>> ---
>>   drivers/phy/Kconfig            |  6 +++
>>   drivers/phy/Makefile           |  1 +
>>   drivers/phy/bcm6348-usbh-phy.c | 94 ++++++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 101 insertions(+)
>>   create mode 100644 drivers/phy/bcm6348-usbh-phy.c
>>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index 3b9a09ce18..cec2130c05 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -59,6 +59,12 @@ config SPL_NOP_PHY
>>   	  This is useful when a driver uses the PHY framework but no real PHY
>>   	  hardware exists.
>>   
>> +config BCM6348_USBH_PHY
>> +	bool "BCM6348 USBH PHY support"
>> +	depends on PHY && ARCH_BMIPS
>> +	help
>> +	  Support for the Broadcom MIPS BCM6348 USBH PHY.
>> +
>>   config PIPE3_PHY
>>   	bool "Support omap's PIPE3 PHY"
>>   	depends on PHY && ARCH_OMAP2PLUS
>> diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile
>> index 668040b0bb..06e01e86eb 100644
>> --- a/drivers/phy/Makefile
>> +++ b/drivers/phy/Makefile
>> @@ -7,6 +7,7 @@
>>   
>>   obj-$(CONFIG_$(SPL_)PHY) += phy-uclass.o
>>   obj-$(CONFIG_$(SPL_)NOP_PHY) += nop-phy.o
>> +obj-$(CONFIG_BCM6348_USBH_PHY) += bcm6348-usbh-phy.o
>>   obj-$(CONFIG_PHY_SANDBOX) += sandbox-phy.o
>>   obj-$(CONFIG_$(SPL_)PIPE3_PHY) += ti-pipe3-phy.o
>>   obj-$(CONFIG_STI_USB_PHY) += sti_usb_phy.o
>> diff --git a/drivers/phy/bcm6348-usbh-phy.c b/drivers/phy/bcm6348-usbh-phy.c
>> new file mode 100644
>> index 0000000000..55e865c53d
>> --- /dev/null
>> +++ b/drivers/phy/bcm6348-usbh-phy.c
>> @@ -0,0 +1,94 @@
>> +/*
>> + * Copyright (C) 2018 Álvaro Fernández Rojas <noltari at gmail.com>
>> + *
>> + * Derived from linux/arch/mips/bcm63xx/usb-common.c:
>> + *	Copyright 2008 Maxime Bizon <mbizon at freebox.fr>
>> + *	Copyright 2013 Florian Fainelli <florian at openwrt.org>
>> + *
>> + * SPDX-License-Identifier: GPL-2.0+
>> + */
>> +
>> +#include <common.h>
>> +#include <clk.h>
>> +#include <dm.h>
>> +#include <generic-phy.h>
>> +#include <reset.h>
>> +#include <asm/io.h>
>> +#include <dm/device.h>
>> +
>> +#define USBH_SETUP_PORT1_EN	BIT(0)
>> +
>> +struct bcm6348_usbh_priv {
>> +	void __iomem *regs;
>> +};
>> +
>> +static int bcm6348_usbh_init(struct phy *phy)
>> +{
>> +	struct bcm6348_usbh_priv *priv = dev_get_priv(phy->dev);
>> +
>> +	writel_be(USBH_SETUP_PORT1_EN, priv->regs);
>> +
>> +	return 0;
>> +}
>> +
>> +static struct phy_ops bcm6348_usbh_ops = {
>> +	.init = bcm6348_usbh_init,
>> +};
>> +
>> +static const struct udevice_id bcm6348_usbh_ids[] = {
>> +	{ .compatible = "brcm,bcm6348-usbh" },
>> +	{ /* sentinel */ }
>> +};
>> +
>> +static int bcm6348_usbh_probe(struct udevice *dev)
>> +{
>> +	struct bcm6348_usbh_priv *priv = dev_get_priv(dev);
>> +	struct reset_ctl rst_ctl;
>> +	struct clk clk;
>> +	fdt_addr_t addr;
>> +	fdt_size_t size;
>> +	int ret;
>> +
>> +	addr = devfdt_get_addr_size_index(dev, 0, &size);
>> +	if (addr == FDT_ADDR_T_NONE)
>> +		return -EINVAL;
>> +
>> +	priv->regs = ioremap(addr, size);
> since you started to convert the other BMIPS related drivers to
> live-tree, shall I pick up the current patches and you send a separate
> patch for the conversion later? Or do you want to resend a v2?
You can pick the current patches and I will send a conversion patch 
later :).

>
>> +
>> +	/* enable usbh clock */
>> +	ret = clk_get_by_name(dev, "usbh", &clk);
>> +	if (ret < 0)
>> +		return ret;
>> +
>> +	ret = clk_enable(&clk);
>> +	if (ret < 0)
>> +		return ret;
>> +
>> +	ret = clk_free(&clk);
>> +	if (ret < 0)
>> +		return ret;
>> +
>> +	/* perform reset */
>> +	ret = reset_get_by_index(dev, 0, &rst_ctl);
>> +	if (ret < 0)
>> +		return ret;
>> +
>> +	ret = reset_deassert(&rst_ctl);
>> +	if (ret < 0)
>> +		return ret;
>> +
>> +	ret = reset_free(&rst_ctl);
>> +	if (ret < 0)
>> +		return ret;
>> +
>> +	return 0;
>> +}
>> +
>> +U_BOOT_DRIVER(bcm6348_usbh) = {
>> +	.name = "bcm6348-usbh",
>> +	.id = UCLASS_PHY,
>> +	.of_match = bcm6348_usbh_ids,
>> +	.ops = &bcm6348_usbh_ops,
>> +	.priv_auto_alloc_size = sizeof(struct bcm6348_usbh_priv),
>> +	.probe = bcm6348_usbh_probe,
>> +};
>>