[U-Boot] [U-Boot, RFC, 1/1] video: rk3288_mipi: check in rk_mipi_ofdata_to_platdata

Philipp Tomsich philipp.tomsich at theobroma-systems.com
Sun Mar 18 16:13:13 UTC 2018


> The error checking should also catch the case that no range has beeen
> defined.
> syscon_get_first_range() returns NULL if no range is defined.
> cf. rk3399_mipi.c
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
> I do not possess the hardware for testing. But the coding is not consistent
> with the coding used in rk3399_mipi.c.
> 
> Why did we duplicate the coding instead of using a common c file?
> ---
>  drivers/video/rockchip/rk3288_mipi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>


More information about the U-Boot mailing list