[U-Boot] [PATCH v8 1/3] Adding TCP and wget into u-boot

[Calvin Johnson]

> > It would be good to have this cosmetic change into a separate patch.
> 
> Ok. But at this stage I'm at the "Forgive me Lord for I know not what
> I do"

😊 . 
Let me know, if you need steps to separate this out. 
To me, it is okay even If you keep this in the same patch.

<snip>
 
> > >  /* Set IP header */
> > > -void net_set_ip_header(uchar *pkt, struct in_addr dest, struct
> > > in_addr source); +void net_set_ip_header(uchar *pkt, struct in_addr
> > > dest, struct in_addr source,
> > > +		       u16  pkt_len, u8 prot);
> > >  void net_set_udp_header(uchar *pkt, struct in_addr dest, int dport,
> > > -				int sport, int len);
> > > -
> > > +			int sport, int len);
> >
> Why do you need this change in the set_udp_header?
> 
> This is a shim to bridge between the original udp to ip procedure call
> and the extra parameters in the enhanced ip procedure call to the ip
> layer for TCP.
> 
> The original udp call is unchanged, because I did not want a
> change to a procedure call to ripple through many applications.

For now, I'm okay with the change you made to net_set_ip_header.

-                               int sport, int len);
-
+                       int sport, int len);
I'm concerned about above 3 line change. Here, you are decreasing indent 
and removing an empty line.  This change may not be required.

Regards
Calvin