[U-Boot] [PATCH 2/2] video: rk3399_mipi: Combine NULL check into IS_ERR_OR_NULL()

Heinrich Schuchardt xypron.glpk at gmx.de
Mon Mar 19 19:28:17 UTC 2018


On 03/19/2018 06:36 PM, Punit Agrawal wrote:
> Signed-off-by: Punit Agrawal <punit.agrawal at arm.com>

Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

> ---
>  drivers/video/rockchip/rk3399_mipi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/rockchip/rk3399_mipi.c b/drivers/video/rockchip/rk3399_mipi.c
> index c6987ff042..b936fcec9b 100644
> --- a/drivers/video/rockchip/rk3399_mipi.c
> +++ b/drivers/video/rockchip/rk3399_mipi.c
> @@ -128,7 +128,7 @@ static int rk_mipi_ofdata_to_platdata(struct udevice *dev)
>  	struct rk_mipi_priv *priv = dev_get_priv(dev);
>  
>  	priv->grf = syscon_get_first_range(ROCKCHIP_SYSCON_GRF);
> -	if (!priv->grf || IS_ERR(priv->grf)) {
> +	if (IS_ERR_OR_NULL(priv->grf)) {
>  		debug("%s: Get syscon grf failed (ret=%p)\n",
>  		      __func__, priv->grf);
>  		return  -ENXIO;
> 



More information about the U-Boot mailing list