[U-Boot] [PATCH] dm: i2c: implement gpio-based I2C deblock

[Heiko Schocher]

Hello Alexander,

Am 23.03.2018 um 07:50 schrieb Heiko Schocher:
> Hello Alexander,
> 
> Am 02.03.2018 um 14:37 schrieb Alexander Kochetkov:
>> The commit extract gpio description from device tree,
>> setup pins and toggle them until I2C slave device
>> release SDA.
>>
>> Any comments? Ideas?
>>
>> Could someone review the patch and tell that should
>> I do with it in order to bring the patch to u-boot?
>>
>> Signed-off-by: Alexander Kochetkov <al.kochet at gmail.com>
>> ---
>>   drivers/i2c/i2c-uclass.c |   95 +++++++++++++++++++++++++++++++++++++++++++++-
>>   1 file changed, 93 insertions(+), 2 deletions(-)
> 
> I am fine with this patch, but checkpatch drops some warnings:
> 
> WARNING: line over 80 characters
> #61: FILE: drivers/i2c/i2c-uclass.c:465:
> +static void i2c_deblock_gpio_run(struct gpio_desc *sda_pin, struct gpio_desc *scl_pin)
> 
> WARNING: line over 80 characters
> #102: FILE: drivers/i2c/i2c-uclass.c:506:
> +               debug("%s: I2C Node '%s' has no 'gpios' property %s\n", __func__,
> 
> WARNING: line over 80 characters
> #113: FILE: drivers/i2c/i2c-uclass.c:517:
> +               debug("%s: I2C Node '%s' has no 'gpio' pinctrl state. %s\n", __func__,
> 
> WARNING: line over 80 characters
> #122: FILE: drivers/i2c/i2c-uclass.c:526:
> +               debug("%s: I2C Node '%s' has no 'default' pinctrl state. %s\n", __func__,
> 
> WARNING: ENOSYS means 'invalid syscall nr' and nothing else
> #147: FILE: drivers/i2c/i2c-uclass.c:551:
> +               return ret ? -ENOSYS : 0;
> 
> 
> Could you fix them, also remove from the commit message the question.

Just triggered an travis build (not finsihed yet), and your patch drops
errors for arm926ejs boards:

https://travis-ci.org/hsdenx/u-boot-i2c/jobs/357258790

So, can you do a full travis build for your patch before sending a v2
and fix the errors it triggers?

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de