[U-Boot] [PATCH 3/3] configs: k2hk_hs_evm: Resync defconfig with non-HS defconfig

Lokesh Vutla lokeshvutla at ti.com
Tue Mar 27 05:33:56 UTC 2018


On Monday 26 March 2018 08:24 PM, Andrew F. Davis wrote:
> On 03/24/2018 11:01 PM, Lokesh Vutla wrote:
>>
>>
>> On Friday 23 March 2018 02:14 AM, Andrew F. Davis wrote:
>>> Signed-off-by: Andrew F. Davis <afd at ti.com>
>>> ---
>>>  configs/k2hk_hs_evm_defconfig | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/configs/k2hk_hs_evm_defconfig b/configs/k2hk_hs_evm_defconfig
>>> index 09ac21e8f3..1cca0caef8 100644
>>> --- a/configs/k2hk_hs_evm_defconfig
>>> +++ b/configs/k2hk_hs_evm_defconfig
>>> @@ -11,6 +11,7 @@ CONFIG_OF_BOARD_SETUP=y
>>>  # CONFIG_USE_BOOTCOMMAND is not set
>>>  CONFIG_SYS_CONSOLE_INFO_QUIET=y
>>>  CONFIG_VERSION_VARIABLE=y
>>> +CONFIG_BOARD_EARLY_INIT_F=y
>>>  # CONFIG_CMD_FLASH is not set
>>>  # CONFIG_CMD_GPIO is not set
>>>  # CONFIG_CMD_GPT is not set
>>> @@ -21,6 +22,8 @@ CONFIG_MTDIDS_DEFAULT="nand0=davinci_nand.0"
>>>  CONFIG_MTDPARTS_DEFAULT="mtdparts=davinci_nand.0:1024k(bootloader)ro,512k(params)ro,-(ubifs)"
>>>  CONFIG_CMD_UBI=y
>>>  CONFIG_OF_CONTROL=y
>>> +CONFIG_DTB_RESELECT=y
>>> +CONFIG_MULTI_DTB_FIT=y
>>
>> I understand you just synced with gp defconfig, but wondering why we
>> require DTB_RESELECT for k2hk? If not required we should probably
>> disable it in gp as well.
>>
> 
> 
> I'm not sure if it is needed either, but I'm not sure which one of these
> fixed the boot issue, so as you noticed I just did a full sync and the
> board started booting again.

commit 3107696784d59 ("defconfig: keystone2: Enable U-boot runtime DTB
detection") enabled these configs. Looks like it is enforced to use
RESELECT on all K2 platforms.


For the entire series:
Reviewed-by: Lokesh vutla <lokeshvutla at ti.com>

Thanks and regards,
Lokesh


> 
> If that config is removed for GP it should be removed for HS, I'll check
> for any further breaks later, but so far what works for GP works for HS.
> 
> If I didn't have plans for merging the GP and HS configs at some point I
> would say defconfig fragments for U-Boot would be something to look into..
> 
> Thanks,
> Andrew
> 
> 
>> Thanks and regards,
>> Lokesh
>>
>>>  CONFIG_ENV_IS_IN_NAND=y
>>>  CONFIG_NET_RANDOM_ETHADDR=y
>>>  CONFIG_DM=y
>>>


More information about the U-Boot mailing list