[U-Boot] [PATCH v2 0/2] dm: i2c: implement gpio-based I2C deblock

Alexander Kochetkov al.kochet at gmail.com
Tue Mar 27 14:52:25 UTC 2018


Hello, Heiko!     

Here is try2 of my previous patch[1].

Done in v2:
- fix checkpatch warnings
- ENOSYS warning still present, but it was in original code also 
  and for me it looks like -ENOSYS must be returned in case of
  missed i2c_deblock_gpio() implementation.
    WARNING: ENOSYS means 'invalid syscall nr' and nothing else
    #138: FILE: drivers/i2c/i2c-uclass.c:552:
    +   return -ENOSYS;
- fix travis build, results can be viewed here:
  https://travis-ci.org/akochetkov/u-boot/builds/358822512
- add property description to i2c.txt

I have question. I declared PIN_SDA, PIN_SCL, PIN_COUNT constants for
i2c-uclass.c. The same constants exist in the i2c-gpio.c. Should I place    
them into i2c.h or may leave as is?

[1] https://lists.denx.de/pipermail/u-boot/2018-March/thread.html#321755

Alexander Kochetkov (2):
  dm: i2c: dts: Add gpios and pinctrl device tree properties
  dm: i2c: implement gpio-based I2C deblock

 doc/device-tree-bindings/i2c/i2c.txt |   13 ++++
 drivers/i2c/i2c-uclass.c             |  118 +++++++++++++++++++++++++++++++---
 2 files changed, 122 insertions(+), 9 deletions(-)

-- 
1.7.9.5



More information about the U-Boot mailing list