[U-Boot] [PATCH v2] Kconfig: cmd: Make networking command dependent on NET

[Joe Hershberger]

On Wed, Mar 28, 2018 at 2:45 AM, Michal Simek <michal.simek at xilinx.com> wrote:
> On 28.3.2018 01:28, Joe Hershberger wrote:
>> Hi Heinrich,
>>
>> On Wed, Feb 28, 2018 at 5:05 PM, Heinrich Schuchardt
>> <xypron.debian at gmx.de> wrote:
>>> On 02/28/2018 02:09 AM, Tom Rini wrote:
>>>>
>>>> On Mon, Feb 26, 2018 at 04:01:02PM +0100, Michal Simek wrote:
>>>>
>>>>> Enable networking command only when NET is enabled.
>>>>> And remove selecting NET for CMD_NET
>>>>>
>>>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>>>> ---
>>>>>
>>>>> Changes in v2:
>>>>> - Check several boards by hand.
>>>>>
>>>>> There is a huge impact on defconfigs because of select NET.
>>>>> But this change makes sense to do but it just needs to be syncup
>>>>> properly. Do we have a tool for this kind of change?
>>>>
>>>>
>>>> So, I've applied this patch, with a good bit of modification.  What I
>>>> wasn't clear about before, sorry, was that we need to make NET default y
>>>> in here too.  However, we also have some decent areas of the code that
>>>> use "CONFIG_CMD_NET" when it really means "CONFIG_NET", at least
>>>> conceptually.  But in order to make everything work as-is today, and
>>>> leave these fixes to a later point in time (as they are fixes and should
>>>> happen) we change some areas today that reference CONFIG_NET to
>>>> reference CONFIG_CMD_NET.  Once net/ gets cleaned up, we can use
>>>> CONFIG_NET without CONFIG_CMD_NET in more area.  It's also not quite
>>>> 100% size-neutral as the topic_miami* boards were playing some games
>>>> that can't quite be done as they were before, but I believe the end
>>>> result is they can now more easily and thoroughly disable the networking
>>>> stuff that intended to be removed.
>>>>
>>>>
>>>
>>> Hello Tom,
>>>
>>> in spite of you comments above I do not understand why you changed
>>> cmd/bootefi.c to depend on CONFIG_CMD_NET instead of CONFIG_NET.
>>>
>>> This was not part of Michal's patch.
>>>
>>> I would prefer if changes would be sent to the list for review *before*
>>> being applied.
>>>
>>> As the patch that you applied is not Michal's patch your authorship should
>>> be documented in the git log.
>>>
>>> I cannot see any reason why network support should be disabled in bootefi if
>>> there are no network commands available.
>>
>> I think there is a fair amount of conflation since some of the basic
>> functions like bootp and dhcp are only accessible through the
>> commands, but you're right that it should be possible to use
>> networking with a static IP and no network commands.
>
> Can you please be more specific how you can use network without network
> commands?

In this case, if EFI is using the network, then U-Boot need not have
any commands that use it. NetConsole is probably another example.

-Joe