[U-Boot] [PATCH 4/9] net: Improve menu options and help for BOOTP options

[Chris Packham]

On Thu, Mar 29, 2018 at 4:18 PM, Chris Packham <judge.packham at gmail.com> wrote:
> On Thu, Mar 29, 2018 at 9:51 AM, Joe Hershberger <joe.hershberger at ni.com> wrote:
>> The options were pretty unhelpful, so improve them some.
>>
>> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
>> ---
>
> Couple of questions below. But with or without changes
>
> Reviewed-by: Chris Packham <judge.packham at gmail.com>
>
>>
>>  cmd/Kconfig | 19 ++++++++++++++-----
>>  1 file changed, 14 insertions(+), 5 deletions(-)
>>
>> diff --git a/cmd/Kconfig b/cmd/Kconfig
>> index 7ef9501..76fd111 100644
>> --- a/cmd/Kconfig
>> +++ b/cmd/Kconfig
>> @@ -1031,23 +1031,32 @@ config CMD_DHCP
>>           Boot image via network using DHCP/TFTP protocol
>>
>>  config BOOTP_BOOTPATH
>> -       bool "Enable BOOTP BOOTPATH"
>> +       bool "Request & store 'rootpath' from BOOTP/DHCP server"
>>         depends on CMD_BOOTP
>> +       help
>> +         Even though the config is called BOOTP_BOOTPATH, it stores the
>> +         path in the variable 'rootpath'.
>>
>>  config BOOTP_DNS
>> -       bool "Enable bootp DNS"
>> +       bool "Request & store 'dnsip' from BOOTP/DHCP server"
>>         depends on CMD_BOOTP
>> +       help
>> +         The primary DNS server is stored as 'dnsip'. If two servers are
>> +         returned, you must set BOOTP_DNS2 to store that second server IP
>> +         also.
>>
>>  config BOOTP_GATEWAY
>> -       bool "Enable BOOTP gateway"
>> +       bool "Request & store 'gatewayip' from BOOTP/DHCP server"
>>         depends on CMD_BOOTP
>
> Should this be default y? It would be pretty annoying if you were to
> turn on bootp/dhcp and forget to enable this as well.
>

Never-mind. Should have looked at the whole series :)

>>
>>  config BOOTP_HOSTNAME
>> -       bool "Enable BOOTP hostname"
>> +       bool "Request & store 'hostname' from BOOTP/DHCP server"
>>         depends on CMD_BOOTP
>> +       help
>> +         The name may or may not be qualified with the local domain name.
>>
>>  config BOOTP_SUBNETMASK
>> -       bool "Enable BOOTP subnetmask"
>> +       bool "Request & store 'netmask' from BOOTP/DHCP server"
>>         depends on CMD_BOOTP
>
> Should this be default y?
>
>>
>>  config BOOTP_PXE
>> --
>> 1.7.11.5
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> https://lists.denx.de/listinfo/u-boot