[U-Boot] [PATCH 4/4] phylib: Don't re-define CONFIG_PHY_MARVELL

Joe Hershberger joe.hershberger at ni.com
Thu Mar 29 03:54:04 UTC 2018


On Wed, Mar 28, 2018 at 7:38 AM, Mario Six <mario.six at gdsys.cc> wrote:
> For certain boards, having CONFIG_PHY_MARVELL in the defconfig will
> result in a redefinition warning, because it is also defined in
> config_phylib_all_drivers.h.
>
> Add a check to stop this redefinition, but keep it for those boards that
> still don't have it in their defconfig.
>
> Signed-off-by: Mario Six <mario.six at gdsys.cc>
> ---
>  include/config_phylib_all_drivers.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/config_phylib_all_drivers.h b/include/config_phylib_all_drivers.h
> index 496ef58db0..264f220c5f 100644
> --- a/include/config_phylib_all_drivers.h
> +++ b/include/config_phylib_all_drivers.h
> @@ -15,7 +15,9 @@
>  #ifdef CONFIG_PHYLIB
>
>  #define CONFIG_PHY_VITESSE
> +#ifndef CONFIG_PHY_MARVELL
>  #define CONFIG_PHY_MARVELL
> +#endif

How many boards are we talking about? Why not just add it to the defconfig?

>  #define CONFIG_PHY_BROADCOM
>  #define CONFIG_PHY_DAVICOM
>  #define CONFIG_PHY_REALTEK
> --
> 2.16.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot


More information about the U-Boot mailing list