[U-Boot] [PATCH v2 12/19] tpm: rename the _extend() function to be _pcr_event()

[Miquel Raynal]

Hi Reinhard,

On Thu, 29 Mar 2018 11:44:28 +0200, Reinhard Pfau
<reinhard.pfau at gdsys.cc> wrote:

> Hi,
> 
> Am 2018-03-29 09:43, schrieb Miquel Raynal:
> > The function currently called _extend() actually does what the
> > specification defines as a _pcr_event(). Rename the function
> > accordingly before implementing the actual _extend() command.  
> > > Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>  
> > ---  
> 
> The TPM 1.2 spec calls this function "TPM_Extend"!
> So renaming this func will be misleading for users of TPM1.2
> devices.
> 
> Since TPM1.2 and TPM2 seems to be really different it might be an
> idea to create a separate command ("tpm2"?) for TPM2 devices...
> (seperate lib, too?)

I used that trick for other commands (prefixing tpm1_ and tpm2_), I
will do the same here to avoid confusion. Thanks for pointing it.

> 
> For this renaming (as user of TPM1.2 devices): NAK
> 
> Greetings,
> Reinhard Pfau
> Guntermann & Drunck GmbH
> 
> 
> 



-- 
Miquel Raynal, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com