[U-Boot] [PATCH 1/2] drivers: i2c: mxc: Update SYS_I2C_MXC_I2C support in Kconfig

Stefano Babic sbabic at denx.de
Thu Mar 29 15:20:05 UTC 2018 

On 13/03/2018 11:11, Sriram Dash wrote:
> 
> 
>> From: Sriram Dash
>> Subject: [PATCH 1/2] drivers: i2c: mxc: Update SYS_I2C_MXC_I2C support in Kconfig
>>
>> NXP layerscape platforms like ls1088a, ls2088a uses MXC I2C Controller.
>> -Remove dependency of MX6 for the same.
>>
>> Update related configs to use Kconfig file.
>> -Add SYS_I2C_MXC_I2C1,_I2C2,_I2C3,_I2C4 in Kconfig -Add
>> CONFIG_SYS_MXC_I2C1_SPEED,_I2C2_,_I2C3_,_I2C4_ in Kconfig -Add
>> CONFIG_SYS_MXC_I2C1_SLAVE,_I2C2_,_I2C3_,_I2C4_ in Kconfig
>>
>> Signed-off-by: Sriram Dash <sriram.dash at nxp.com>
>> Signed-off-by: Priyanka Jain <priyanka.jain at nxp.com>
>> ---
> 
> Hello Stefano,
> 
> Any updates.
> 

Sorry for late answer - I have no comments about these patches, I have
not seen any comments at all, I will aply them.

Regards,
Stefano


>> arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 23 ++++++++
>> drivers/i2c/Kconfig                       | 89 +++++++++++++++++++++++++++++--
>> include/configs/ls1012a_common.h          |  3 --
>> include/configs/ls1043a_common.h          |  5 --
>> include/configs/ls1046a_common.h          |  5 --
>> include/configs/ls1088a_common.h          |  5 --
>> include/configs/ls2080a_common.h          |  5 --
>> include/configs/ls2080a_emu.h             |  3 --
>> include/configs/ls2080a_simu.h            |  3 --
>> 9 files changed, 109 insertions(+), 32 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig b/arch/arm/cpu/armv8/fsl-
>> layerscape/Kconfig
>> index cefbdfe..ebccd16 100644
>> --- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
>> +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
>> @@ -12,6 +12,9 @@ config ARCH_LS1012A
>> 	select SYS_FSL_ERRATUM_A009008
>> 	select ARCH_EARLY_INIT_R
>> 	select BOARD_EARLY_INIT_F
>> +	select SYS_I2C_MXC
>> +	select SYS_I2C_MXC_I2C1
>> +	select SYS_I2C_MXC_I2C2
>> 	imply PANIC_HANG
>>
>> config ARCH_LS1043A
>> @@ -37,6 +40,11 @@ config ARCH_LS1043A
>> 	select SYS_FSL_HAS_DDR4
>> 	select ARCH_EARLY_INIT_R
>> 	select BOARD_EARLY_INIT_F
>> +	select SYS_I2C_MXC
>> +	select SYS_I2C_MXC_I2C1
>> +	select SYS_I2C_MXC_I2C2
>> +	select SYS_I2C_MXC_I2C3
>> +	select SYS_I2C_MXC_I2C4
>> 	imply SCSI
>> 	imply SCSI_AHCI
>> 	imply CMD_PCI
>> @@ -64,6 +72,11 @@ config ARCH_LS1046A
>> 	select SYS_FSL_SRDS_2
>> 	select ARCH_EARLY_INIT_R
>> 	select BOARD_EARLY_INIT_F
>> +	select SYS_I2C_MXC
>> +	select SYS_I2C_MXC_I2C1
>> +	select SYS_I2C_MXC_I2C2
>> +	select SYS_I2C_MXC_I2C3
>> +	select SYS_I2C_MXC_I2C4
>> 	imply SCSI
>> 	imply SCSI_AHCI
>>
>> @@ -94,6 +107,11 @@ config ARCH_LS1088A
>> 	select FSL_TZASC_1
>> 	select ARCH_EARLY_INIT_R
>> 	select BOARD_EARLY_INIT_F
>> +	select SYS_I2C_MXC
>> +	select SYS_I2C_MXC_I2C1
>> +	select SYS_I2C_MXC_I2C2
>> +	select SYS_I2C_MXC_I2C3
>> +	select SYS_I2C_MXC_I2C4
>> 	imply SCSI
>> 	imply PANIC_HANG
>>
>> @@ -134,6 +152,11 @@ config ARCH_LS2080A
>> 	select SYS_FSL_ERRATUM_A009203
>> 	select ARCH_EARLY_INIT_R
>> 	select BOARD_EARLY_INIT_F
>> +	select SYS_I2C_MXC
>> +	select SYS_I2C_MXC_I2C1
>> +	select SYS_I2C_MXC_I2C2
>> +	select SYS_I2C_MXC_I2C3
>> +	select SYS_I2C_MXC_I2C4
>> 	imply PANIC_HANG
>>
>> config FSL_LSCH2
>> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig index 17d21bb..7cad493
>> 100644
>> --- a/drivers/i2c/Kconfig
>> +++ b/drivers/i2c/Kconfig
>> @@ -149,13 +149,96 @@ config SYS_I2C_MESON
>> 	  both 7-bit and 10-bit addresses.
>>
>> config SYS_I2C_MXC
>> -	bool "NXP i.MX I2C driver"
>> -	depends on MX6
>> +	bool "NXP MXC I2C driver"
>> 	help
>> -	  Add support for the NXP i.MX I2C driver. This supports upto for bus
>> +	  Add support for the NXP I2C driver. This supports upto for bus
>> 	  channels and operating on standard mode upto 100 kbits/s and fast
>> 	  mode upto 400 kbits/s.
>>
>> +if SYS_I2C_MXC
>> +config SYS_I2C_MXC_I2C1
>> +	bool "NXP MXC I2C1"
>> +	help
>> +	 Add support for NXP MXC I2C Controller 1.
>> +	 Required for SoCs which have I2C MXC controller 1 eg LS1088A, LS2080A
>> +
>> +config SYS_I2C_MXC_I2C2
>> +	bool "NXP MXC I2C2"
>> +	help
>> +	 Add support for NXP MXC I2C Controller 2.
>> +	 Required for SoCs which have I2C MXC controller 2 eg LS1088A, LS2080A
>> +
>> +config SYS_I2C_MXC_I2C3
>> +	bool "NXP MXC I2C3"
>> +	help
>> +	 Add support for NXP MXC I2C Controller 3.
>> +	 Required for SoCs which have I2C MXC controller 3 eg LS1088A, LS2080A
>> +
>> +config SYS_I2C_MXC_I2C4
>> +	bool "NXP MXC I2C4"
>> +	help
>> +	 Add support for NXP MXC I2C Controller 4.
>> +	 Required for SoCs which have I2C MXC controller 4 eg LS1088A, LS2080A
>> +endif
>> +
>> +if SYS_I2C_MXC_I2C1
>> +config SYS_MXC_I2C1_SPEED
>> +	int "I2C Channel 1 speed"
>> +	default 40000000 if TARGET_LS2080A_SIMU || TARGET_LS2080A_EMU
>> +	default 100000
>> +	help
>> +	 MXC I2C Channel 1 speed
>> +
>> +config SYS_MXC_I2C1_SLAVE
>> +	int "I2C1 Slave"
>> +	default 0
>> +	help
>> +	 MXC I2C1 Slave
>> +endif
>> +
>> +if SYS_I2C_MXC_I2C2
>> +config SYS_MXC_I2C2_SPEED
>> +	int "I2C Channel 2 speed"
>> +	default 40000000 if TARGET_LS2080A_SIMU || TARGET_LS2080A_EMU
>> +	default 100000
>> +	help
>> +	 MXC I2C Channel 2 speed
>> +
>> +config SYS_MXC_I2C2_SLAVE
>> +	int "I2C2 Slave"
>> +	default 0
>> +	help
>> +	 MXC I2C2 Slave
>> +endif
>> +
>> +if SYS_I2C_MXC_I2C3
>> +config SYS_MXC_I2C3_SPEED
>> +	int "I2C Channel 3 speed"
>> +	default 100000
>> +	help
>> +	 MXC I2C Channel 3 speed
>> +
>> +config SYS_MXC_I2C3_SLAVE
>> +	int "I2C3 Slave"
>> +	default 0
>> +	help
>> +	 MXC I2C3 Slave
>> +endif
>> +
>> +if SYS_I2C_MXC_I2C4
>> +config SYS_MXC_I2C4_SPEED
>> +	int "I2C Channel 4 speed"
>> +	default 100000
>> +	help
>> +	 MXC I2C Channel 4 speed
>> +
>> +config SYS_MXC_I2C4_SLAVE
>> +	int "I2C4 Slave"
>> +	default 0
>> +	help
>> +	 MXC I2C4 Slave
>> +endif
>> +
>> config SYS_I2C_OMAP24XX
>> 	bool "TI OMAP2+ I2C driver"
>> 	depends on ARCH_OMAP2PLUS
>> diff --git a/include/configs/ls1012a_common.h
>> b/include/configs/ls1012a_common.h
>> index 7dbe231..61aeaf9 100644
>> --- a/include/configs/ls1012a_common.h
>> +++ b/include/configs/ls1012a_common.h
>> @@ -81,9 +81,6 @@
>>
>> /* I2C */
>> #define CONFIG_SYS_I2C
>> -#define CONFIG_SYS_I2C_MXC
>> -#define CONFIG_SYS_I2C_MXC_I2C1		/* enable I2C bus 1 */
>> -#define CONFIG_SYS_I2C_MXC_I2C2		/* enable I2C bus 2 */
>>
>> #define CONFIG_CONS_INDEX       1
>> #define CONFIG_SYS_NS16550_SERIAL
>> diff --git a/include/configs/ls1043a_common.h
>> b/include/configs/ls1043a_common.h
>> index 67b5ea7..baf1305 100644
>> --- a/include/configs/ls1043a_common.h
>> +++ b/include/configs/ls1043a_common.h
>> @@ -152,11 +152,6 @@
>>
>> /* I2C */
>> #define CONFIG_SYS_I2C
>> -#define CONFIG_SYS_I2C_MXC
>> -#define CONFIG_SYS_I2C_MXC_I2C1
>> -#define CONFIG_SYS_I2C_MXC_I2C2
>> -#define CONFIG_SYS_I2C_MXC_I2C3
>> -#define CONFIG_SYS_I2C_MXC_I2C4
>>
>> /* PCIe */
>> #ifndef SPL_NO_PCIE
>> diff --git a/include/configs/ls1046a_common.h
>> b/include/configs/ls1046a_common.h
>> index bef4dd4..5667ce7 100644
>> --- a/include/configs/ls1046a_common.h
>> +++ b/include/configs/ls1046a_common.h
>> @@ -130,11 +130,6 @@
>>
>> /* I2C */
>> #define CONFIG_SYS_I2C
>> -#define CONFIG_SYS_I2C_MXC
>> -#define CONFIG_SYS_I2C_MXC_I2C1
>> -#define CONFIG_SYS_I2C_MXC_I2C2
>> -#define CONFIG_SYS_I2C_MXC_I2C3
>> -#define CONFIG_SYS_I2C_MXC_I2C4
>>
>> /* PCIe */
>> #define CONFIG_PCIE1		/* PCIE controller 1 */
>> diff --git a/include/configs/ls1088a_common.h
>> b/include/configs/ls1088a_common.h
>> index 61c30c9..d7b81f3 100644
>> --- a/include/configs/ls1088a_common.h
>> +++ b/include/configs/ls1088a_common.h
>> @@ -78,11 +78,6 @@
>>
>> /* I2C */
>> #define CONFIG_SYS_I2C
>> -#define CONFIG_SYS_I2C_MXC
>> -#define CONFIG_SYS_I2C_MXC_I2C1		/* enable I2C bus 1 */
>> -#define CONFIG_SYS_I2C_MXC_I2C2		/* enable I2C bus 2 */
>> -#define CONFIG_SYS_I2C_MXC_I2C3		/* enable I2C bus 3 */
>> -#define CONFIG_SYS_I2C_MXC_I2C4		/* enable I2C bus 4 */
>>
>> /* Serial Port */
>> #define CONFIG_CONS_INDEX       1
>> diff --git a/include/configs/ls2080a_common.h
>> b/include/configs/ls2080a_common.h
>> index b995513..6ad5e36 100644
>> --- a/include/configs/ls2080a_common.h
>> +++ b/include/configs/ls2080a_common.h
>> @@ -85,11 +85,6 @@
>>
>> /* I2C */
>> #define CONFIG_SYS_I2C
>> -#define CONFIG_SYS_I2C_MXC
>> -#define CONFIG_SYS_I2C_MXC_I2C1		/* enable I2C bus 1 */
>> -#define CONFIG_SYS_I2C_MXC_I2C2		/* enable I2C bus 2 */
>> -#define CONFIG_SYS_I2C_MXC_I2C3		/* enable I2C bus 3 */
>> -#define CONFIG_SYS_I2C_MXC_I2C4		/* enable I2C bus 4 */
>>
>> /* Serial Port */
>> #define CONFIG_CONS_INDEX       1
>> diff --git a/include/configs/ls2080a_emu.h b/include/configs/ls2080a_emu.h index
>> 6b34edf..c2fdc4d 100644
>> --- a/include/configs/ls2080a_emu.h
>> +++ b/include/configs/ls2080a_emu.h
>> @@ -12,9 +12,6 @@
>> #define CONFIG_SYS_CLK_FREQ	100000000
>> #define CONFIG_DDR_CLK_FREQ	133333333
>>
>> -#define CONFIG_SYS_MXC_I2C1_SPEED	40000000
>> -#define CONFIG_SYS_MXC_I2C2_SPEED	40000000
>> -
>> #define CONFIG_DDR_SPD
>> #define CONFIG_SYS_FSL_DDR_EMU		/* Support emulator */
>> #define SPD_EEPROM_ADDRESS1	0x51
>> diff --git a/include/configs/ls2080a_simu.h b/include/configs/ls2080a_simu.h index
>> dad1090..103ebec 100644
>> --- a/include/configs/ls2080a_simu.h
>> +++ b/include/configs/ls2080a_simu.h
>> @@ -12,9 +12,6 @@
>> #define CONFIG_SYS_CLK_FREQ	100000000
>> #define CONFIG_DDR_CLK_FREQ	133333333
>>
>> -#define CONFIG_SYS_MXC_I2C1_SPEED	40000000
>> -#define CONFIG_SYS_MXC_I2C2_SPEED	40000000
>> -
>> #define CONFIG_DIMM_SLOTS_PER_CTLR		1
>> #define CONFIG_CHIP_SELECTS_PER_CTRL		4
>> #ifdef CONFIG_SYS_FSL_HAS_DP_DDR
>> --
>> 1.9.1
> 


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

More information about the U-Boot mailing list