[U-Boot] [PATCH] stdio_dev.h: Drop the video section as it is unused

Peter Robinson pbrobinson at gmail.com
Wed May 2 23:38:34 UTC 2018


On Wed, May 2, 2018 at 11:09 PM, Tom Rini <trini at konsulko.com> wrote:
> With tighter build flags the fact that this header referenced
> uchar/ushort without including what typedefs it causes warnings.  Rather
> than add another include here, drop the section in question as it is
> unused.

This doesn't completely fix my problem, with this patch applied I
still get a build failure from this file this time for MAX_FILES, so
it likely needs a "#include <stdio.h>" as well which was added via the
include common.h in my previous patch

Error was:
/builddir/build/BUILD/u-boot-2018.05-rc3/include/stdio_dev.h:55:26:
error: 'MAX_FILES' undeclared here (not in a function)

Peter

> Reported-by: Peter Robinson <pbrobinson at gmail.com>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
>  include/stdio_dev.h | 18 ------------------
>  1 file changed, 18 deletions(-)
>
> diff --git a/include/stdio_dev.h b/include/stdio_dev.h
> index 3164fa2a5579..1ea8bff47bab 100644
> --- a/include/stdio_dev.h
> +++ b/include/stdio_dev.h
> @@ -49,24 +49,6 @@ struct stdio_dev {
>  };
>
>  /*
> - * VIDEO EXTENSIONS
> - */
> -#define VIDEO_FORMAT_RGB_INDEXED       0x0000
> -#define VIDEO_FORMAT_RGB_DIRECTCOLOR   0x0001
> -#define VIDEO_FORMAT_YUYV_4_4_4                0x0010
> -#define VIDEO_FORMAT_YUYV_4_2_2                0x0011
> -
> -typedef struct {
> -       void *address;                  /* Address of framebuffer               */
> -       ushort  width;                  /* Horizontal resolution                */
> -       ushort  height;                 /* Vertical resolution                  */
> -       uchar   format;                 /* Format                               */
> -       uchar   colors;                 /* Colors number or color depth         */
> -       void (*setcolreg) (int, int, int, int);
> -       void (*getcolreg) (int, void *);
> -} video_ext_t;
> -
> -/*
>   * VARIABLES
>   */
>  extern struct stdio_dev *stdio_devices[];
> --
> 2.7.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot


More information about the U-Boot mailing list