[U-Boot] [PATCHv2 2/2] stdio_names: Ensure MAX_NAMES is defined before use, don't use 3 directly

[Tom Rini]

On Thu, May 03, 2018 at 03:12:47PM +0100, Peter Robinson wrote:
> On Thu, May 3, 2018 at 2:12 PM, Tom Rini <trini at konsulko.com> wrote:
> > With tighter build flags the fact that <stdio_dev.h> doesn't have a
> > reference back to MAX_NAMES causes an error.  Include <stdio.h> here and
> > then in common/console.c use MAX_NAMES rather than 3 when working with
> > stdio_names.
> >
> > Reported-by: Peter Robinson <pbrobinson at gmail.com>
> > Signed-off-by: Tom Rini <trini at konsulko.com>
> > ---
> > Changes in v2:
> > - New patch
> > ---
> >  common/console.c    | 4 ++--
> >  include/stdio_dev.h | 1 +
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/common/console.c b/common/console.c
> > index 0e0295514b21..f1a5e95c8f39 100644
> > --- a/common/console.c
> > +++ b/common/console.c
> > @@ -847,7 +847,7 @@ done:
> >
> >  #ifdef CONFIG_SYS_CONSOLE_ENV_OVERWRITE
> >         /* set the environment variables (will overwrite previous env settings) */
> > -       for (i = 0; i < 3; i++) {
> > +       for (i = 0; i < MAX_NAMES; i++) {
> 
> I think you mean MAX_FILES? With MAX_NAMES it fails, with MAX_FILES it builds.
> 
> With the that change, if it's correct:
> Tested-by: Peter Robinson <pbrobinson at gmail.com>

If anyone is wonder if I'll ever learn to not post something I quickly
did and was sure it was right, the answer is no.  But I don't push those
changes out (on purpose) at least!  I'll fix it up before merging,
thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180503/c20eeaff/attachment.sig>