[U-Boot] [PATCH v2 3/5] regmap: Define regmap_{get,set}

[Mario Six]

Hi Simon,

On Thu, May 3, 2018 at 4:33 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Mario,
>
> On 27 April 2018 at 06:52, Mario Six <mario.six at gdsys.cc> wrote:
>> It would be convenient if one could use the regmap API in conjunction
>> with register maps defined as structs (i.e. structs that directly mirror
>> the memory layout of the registers in question). A similar approach was
>> planned with the regmap_write32/regmap_read32 macros, but was never
>> used.
>>
>> Hence, implement regmap_set/regmap_range_set and
>> regmap_get/regmap_range_get macros, which, given a register map, a
>> struct describing the layout of the register map, and a member name
>> automatically produce regmap_read/regmap_write calls that access the
>> specified member in the register map.
>>
>> Signed-off-by: Mario Six <mario.six at gdsys.cc>
>> ---
>>
>> v1 -> v2:
>> New in v2
>>
>> ---
>>  include/regmap.h | 14 ++++++++++----
>>  1 file changed, 10 insertions(+), 4 deletions(-)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> Please can you add function comments and also a test that calls these?
> I think Masahiro made a start.
>

OK, I'll add some tests for v3.

> Regards,
> Simon
>

Best regards,
Mario