[U-Boot] [PATCH RFCv2 0/6] Beginning of migration of MPC8xx to DM model

[Joakim Tjernlund]

On Fri, 2018-05-04 at 12:33 +0200, Christophe LEROY wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> 
> Hi Mario,
> 
> Le 04/05/2018 à 11:56, Mario Six a écrit :
> > Hi Christophe,
> > 
> > On Fri, May 4, 2018 at 7:20 AM, Christophe LEROY
> > <christophe.leroy at c-s.fr> wrote:
> > > Hello,
> > > 
> > > 
> > > Le 16/03/2018 à 17:32, Christophe Leroy a écrit :
> > > > 
> > > > This serie is the beginning of MPC8xx migration to DM model.
> > > 
> > > 
> > > I didn't get any feedback on this serie. I don't feel totally confortable as
> > > it is my first implementation of DM and also the first time powerpc uses DT
> > > for U-boot.
> > > 
> > > I'd rather someone look at it.
> > > 
> > 
> > One thing I'm noticing: Are you setting up pre-relocation malloc? Since MPC8xx
> > is another old powerpc platform, I suspect that the start.S doesn't do it, and
> > DM needs it to function correctly.
> 
> Yes, I did it with the following patch:
> 
> https://patchwork.ozlabs.org/patch/886980/

Hi 

Had a quick look at that patch and it looks like you lost zeroing the
stack frame (stwu	r0, -4(r1) ...) ?

Also, don't use touch r1 until the stack is ready, otherwise gdb will
try accessing the stack if you single step over this part.

 Jocke