[U-Boot] [RFC PATCH v2 15/20] fastboot: Merge boot common across USB and UDP

Jocelyn Bohr bohr at google.com
Mon May 7 21:59:04 UTC 2018


Optional nit: Consider renaming "fastbootcmd" to "fb_bootcmd" or similar.
IMO "fastbootcmd" is
ambiguous as there can be multiple env variable commands related to
fastboot.

On Thu, May 3, 2018 at 2:21 PM Joe Hershberger <joe.hershberger at ni.com>
wrote:

> On Mon, Apr 30, 2018 at 3:32 AM, Alex Kiernan <alex.kiernan at gmail.com>
> wrote:
> > Merge USB and UDP boot code. The USB implementation stays the same, but
> > UDP no longer passes an fdt. We introduce a new environment variable
> > 'fastbootcmd' which if set overrides the hardcoded boot command, setting
> > this then allows the UDP implementation to remain the same. If after
> > running 'fastbootcmd' the board has not booted, control is returned
> > to U-Boot and the fastboot process ends.
> >
> > Signed-off-by: Alex Kiernan <alex.kiernan at gmail.com>
>
> Nit below...
>
> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
>

Reviewed-by: Jocelyn Bohr <bohr at google.com>


More information about the U-Boot mailing list