[U-Boot] [U-Boot, v2, 1/2] rockchip: enable SYS_NS16550 for all SoCs by default

Dr. Philipp Tomsich philipp.tomsich at theobroma-systems.com
Tue May 8 07:41:32 UTC 2018


Kever,

Could you analyse and provide (against master) a patch for this?
We’ll need to catch any left-overs from your changes at the start of the cycle
before we try to merge any of the more invasive changes you have in-flight.

Thanks,
Philipp.

> On 8 May 2018, at 09:30, Jonathan Gray <jsg at jsg.id.au> wrote:
> 
> On Thu, Apr 26, 2018 at 09:05:37AM +0200, Philipp Tomsich wrote:
>>> All rockchip SoCs can use ns16550 driver, enable it for all
>>> and set SYS_NS16550_MEM32 for all SoCs.
>>> 
>>> Version-changes: 2
>>> - use imply instead of select
>>> 
>>> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
>>> Acked-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>>> Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>>> ---
>>> 
>>> Changes in v2: None
>>> 
>>> arch/arm/Kconfig                  | 1 +
>>> arch/arm/mach-rockchip/Kconfig    | 1 -
>>> include/configs/rk3036_common.h   | 3 ---
>>> include/configs/rk3128_common.h   | 2 --
>>> include/configs/rk3188_common.h   | 2 --
>>> include/configs/rk322x_common.h   | 1 -
>>> include/configs/rk3288_common.h   | 2 --
>>> include/configs/rk3328_common.h   | 2 --
>>> include/configs/rk3368_common.h   | 2 --
>>> include/configs/rk3399_common.h   | 2 --
>>> include/configs/rockchip-common.h | 2 ++
>>> include/configs/rv1108_common.h   | 3 ---
>>> 12 files changed, 3 insertions(+), 20 deletions(-)
>>> 
>> 
>> Applied to u-boot-rockchip, thanks!
> 
> With U-Boot 2018.05 there is no serial console output on tinker-rk3288,
> a regression from 2018.03.  I have bisected it to this commit.
> 
> Reverting c3c0331db1fb7b1f4ff41e144fc04353b37c785c and
> eb3d707e99fcd2213d5f8f0fe4ae53ad416b377e restores serial output with
> 2018.05.
> 
> c3c0331db1fb7b1f4ff41e144fc04353b37c785c is the first bad commit
> commit c3c0331db1fb7b1f4ff41e144fc04353b37c785c
> Author: Kever Yang <kever.yang at rock-chips.com <mailto:kever.yang at rock-chips.com>>
> Date:   Thu Apr 19 11:37:09 2018 +0800
> 
>    rockchip: enable SYS_NS16550 for all SoCs by default
> 
>    All rockchip SoCs can use ns16550 driver, enable it for all
>    and set SYS_NS16550_MEM32 for all SoCs.
> 
>    Version-changes: 2
>    - use imply instead of select
> 
>    Signed-off-by: Kever Yang <kever.yang at rock-chips.com <mailto:kever.yang at rock-chips.com>>
>    Acked-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com <mailto:philipp.tomsich at theobroma-systems.com>>
>    Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com <mailto:philipp.tomsich at theobroma-systems.com>>
> 
> :040000 040000 f7cc8b28ae8179fdc15896bbb55279f205a54008 d07108bbf467735f31f31c083a9068dff71da247 M      arch
> :040000 040000 d0a0422fc55afdcb5abb82f24b9a0af8de3d39a6 33c7fcf6f28f44a8c416f95313e7a30b2f73f8f0 M      include



More information about the U-Boot mailing list