[U-Boot] [PATCH] efi_loader: fix off-by-one bug in efi_get_variable

[Alexander Graf]

On 05/09/2018 12:50 AM, Ivan Gorinov wrote:
> efi_get_variable() always stores an extra zero byte after the output data.
> When the returned data size matches the output buffer size, the extra zero
> byte is stored past the end of the output buffer.
>
> Signed-off-by: Ivan Gorinov <ivan.gorinov at intel.com>

Thanks to the memset right above the loop we can just remove the *mem = 
0 line altogether, no?

Alex

> ---
>   lib/efi_loader/efi_variable.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c
> index 6c177da..d031338 100644
> --- a/lib/efi_loader/efi_variable.c
> +++ b/lib/efi_loader/efi_variable.c
> @@ -68,11 +68,11 @@ static const char *hex2mem(u8 *mem, const char *hexstr, int count)
>   	do {
>   		int nibble;
>   
> -		*mem = 0;
> -
>   		if (!count || !*hexstr)
>   			break;
>   
> +		*mem = 0;
> +
>   		nibble = hex(*hexstr);
>   		if (nibble < 0)
>   			break;