[U-Boot] [PATCH 1/1] efi_loader: always check parameters in efi_cout_query_mode()

[Heinrich Schuchardt]

On 05/09/2018 11:18 PM, Tom Rini wrote:
> On Wed, May 09, 2018 at 11:13:37PM +0200, Heinrich Schuchardt wrote:
>> On 05/09/2018 10:00 PM, Tom Rini wrote:
>>> On Sun, Apr 29, 2018 at 08:02:46PM +0200, Heinrich Schuchardt wrote:
>>>
>>>> If we cannot determine the size of the serial terminal we still have
>>>> to check the parameters of efi_cout_query_mode().
>>>>
>>>> Querying the size of the serial terminal drains the keyboard buffer.
>>>> So make sure we do this during the initialization and not in the midst
>>>> of an EFI application.
>>>>
>>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>>
>> <snip />
>>
>>>
>>> Even without this patch with a newer gcc we see:
>>> https://travis-ci.org/trini/u-boot/jobs/376853382#L916
>>>
>>> Can you address that while doing this fixup as well?  Thanks!
>>>
>>
>> I don't doubt there is an issue. But why don't we see the error outside
>> of Travis CI? Do we set different flags when building?
>>
>> Can't see it with
>> gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
>> nor with
>> gcc (Debian 7.3.0-17) 7.3.0
> 
> As a warning or an error?  The toolchain in question is
> https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/7.3.0/x86_64-gcc-7.3.0-nolibc_x86_64-linux.tar.xz
> and on that specific branch is where I'm testing moving buildman up.
> Thanks!

When I run

git checkout master
make qemu-x86_defconfig
make -j6

I see no warning.

I strongly dislike using buildman locally because it pulls in binaries
from some dubious source which are not even signed.

Best regards

Heinrich

> 
> 
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
>