[U-Boot] [PATCH] video: sunxi: de2: Reserve the fb region in the EFI memory map

[Heinrich Schuchardt]

On 05/04/2018 10:26 AM, Emmanuel Vadot wrote:
> If compile with support for the efi loader we need to mark the pages
> allocated for the framebuffer as reserved so the kernel won't attempt
> to use them for other uses.
> 
> Signed-off-by: Emmanuel Vadot <manu at freebsd.org>
> ---
>  drivers/video/sunxi/sunxi_de2.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/video/sunxi/sunxi_de2.c b/drivers/video/sunxi/sunxi_de2.c
> index 860187323c..563e4b583d 100644
> --- a/drivers/video/sunxi/sunxi_de2.c
> +++ b/drivers/video/sunxi/sunxi_de2.c
> @@ -10,6 +10,7 @@
>  #include <display.h>
>  #include <dm.h>
>  #include <edid.h>
> +#include <efi_loader.h>
>  #include <fdtdec.h>
>  #include <fdt_support.h>
>  #include <video.h>
> @@ -222,6 +223,13 @@ static int sunxi_de2_init(struct udevice *dev, ulong fbbase,
>  	uc_priv->bpix = l2bpp;
>  	debug("fb=%lx, size=%d %d\n", fbbase, uc_priv->xsize, uc_priv->ysize);
>  
> +#ifdef CONFIG_EFI_LOADER
> +	efi_add_memory_map(fbbase,
> +			   ALIGN(timing.hactive.typ * timing.vactive.typ *
> +			   (1 << l2bpp) / 8, EFI_PAGE_SIZE) >> EFI_PAGE_SHIFT,
> +			   EFI_RESERVED_MEMORY_TYPE, false);

Should fbbase not be EFI_PAGE_SIZE (4k) aligned you would have to round
it down.

I wonder why below we use macro VNBYTES() but not here.

Otherwise

Acked-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

> +#endif
> +
>  	return 0;
>  }
>  
>