[U-Boot] [PATCH v2 1/6] kconfig: re-sync with Linux 4.17-rc4

[Eugeniu Rosca]

Hello Petr,

On Sat, May 12, 2018 at 08:25:56PM +0200, Petr Vorel wrote:
> Hi Eugeniu,
> 
> > My testing was limited to:
> > - make defconfig all
> > - make ARCH=arm CROSS_COMPILE=aarch64-linux-gnu- r8a7795_ulcb_defconfig all
> > - comparing .config before and after the re-sync
> > - running the newly imported Kconfig unit tests as seen below:
> 
> I tested whole patch-set with the other options:
> make config
> make defconfig
> make menuconfig
> make xconfig
> make gconfig
> make oldconfig
> 
> > Reviewed-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> > Signed-off-by: Eugeniu Rosca <erosca at de.adit-jv.com>
> Tested-by: Petr Vorel <petr.vorel at gmail.com>

Many thanks for testing!

> 
> > $ make testconfig
> 
> > ============================= test session starts =============================
> > scripts/kconfig/tests/auto_submenu/__init__.py::test PASSED             [  7%]
> > scripts/kconfig/tests/choice/__init__.py::test_oldask0 PASSED           [ 14%]
> > scripts/kconfig/tests/choice/__init__.py::test_oldask1 PASSED           [ 21%]
> > scripts/kconfig/tests/choice/__init__.py::test_allyes PASSED            [ 28%]
> > scripts/kconfig/tests/choice/__init__.py::test_allmod PASSED            [ 35%]
> > scripts/kconfig/tests/choice/__init__.py::test_allno PASSED             [ 42%]
> > scripts/kconfig/tests/choice/__init__.py::test_alldef PASSED            [ 50%]
> > scripts/kconfig/tests/choice_value_with_m_dep/__init__.py::test PASSED  [ 57%]
> > scripts/kconfig/tests/err_recursive_inc/__init__.py::test PASSED        [ 64%]
> > scripts/kconfig/tests/inter_choice/__init__.py::test PASSED             [ 71%]
> > scripts/kconfig/tests/new_choice_with_dep/__init__.py::test PASSED      [ 78%]
> > scripts/kconfig/tests/no_write_if_dep_unmet/__init__.py::test PASSED    [ 85%]
> > scripts/kconfig/tests/rand_nested_choice/__init__.py::test PASSED       [ 92%]
> > scripts/kconfig/tests/warn_recursive_dep/__init__.py::test PASSED       [100%]
> > ========================== 14 passed in 0.34 seconds ==========================
> 
> When applied all 6 patches, I got several errors (see bellow).
> I tested in on 2 distros (Debian unstable and openSUSE Tumbleweed).
> The code I applied is here, did I make error when applying patches?
> https://github.com/pevik/u-boot/tree/eugeniu/kconfig.v2

I checked your branch and got some interesting conclusions.
Here is the diff between my and your version of commit ("kconfig:
re-sync with Linux 4.17-rc4"):

$ git diff <eugeniu> <petr>
 scripts/kconfig/tests/auto_submenu/expected_stdout        | 14 +++++++-------
 scripts/kconfig/tests/choice/oldask0_expected_stdout      | 14 +++++++-------
 scripts/kconfig/tests/choice/oldask1_expected_stdout      | 12 ++++++------
 scripts/kconfig/tests/new_choice_with_dep/expected_stdout |  4 ++--
 4 files changed, 22 insertions(+), 22 deletions(-)

Here is the same diff ignoring whitespace:

$ git diff -w <eugeniu> <petr>
 scripts/kconfig/tests/auto_submenu/expected_stdout        | 0
 scripts/kconfig/tests/choice/oldask0_expected_stdout      | 0
 scripts/kconfig/tests/choice/oldask1_expected_stdout      | 0
 scripts/kconfig/tests/new_choice_with_dep/expected_stdout | 0
 4 files changed, 0 insertions(+), 0 deletions(-)

So, it seems like all the trailing white-space from above files
disappeared on your branch, after applying the patches from the
email client (who did this?...).

I didn't expect that trailing white-space to be of any value for the
test results, but it turns out it is! With the whitespace removed, I can
also reproduce the failures of "make testconfig".

I am not familiar with pytest, but, based on what we see here, it looks
like every single character stored in *xpected_stdout files (including
whitespace at the end of lines) matters for the test to pass.

I wonder if Kconfig could avoid printing whitespace in command line
user dialogs. Then maybe those space characters could be removed from
the "*xpected_stdout" files.

Masahiro?

Thanks again!

Best regards,
Eugeniu.