[U-Boot] [PATCH v2 1/6] kconfig: re-sync with Linux 4.17-rc4

Eugeniu Rosca roscaeugeniu at gmail.com
Sun May 13 20:43:56 UTC 2018


On Sun, May 13, 2018 at 10:52:07PM +0900, Masahiro Yamada wrote:
> 2018-05-13 4:17 GMT+09:00 Eugeniu Rosca <roscaeugeniu at gmail.com>:
> > I wonder if Kconfig could avoid printing whitespace in command line
> > user dialogs. Then maybe those space characters could be removed from
> > the "*xpected_stdout" files.
> 
> 
> 'make config' display a space at the end of line
> when prompting user input.
> 
> This makes the input readable, like follows:
> 
> *
> * Linux/x86 4.17.0-rc4 Kernel Configuration
> *
> 64-bit kernel (64BIT) [Y/n/?] y
> *
> * General setup
> *
> Cross-compiler tool prefix (CROSS_COMPILE) []
> Compile also drivers which will not load (COMPILE_TEST) [N/y/?] y
> 
> 
> 
> I think you are suggesting to remove a space, like follows:
> 
> *
> * Linux/x86 4.17.0-rc4 Kernel Configuration
> *
> 64-bit kernel (64BIT) [Y/n/?]y
> *
> * General setup
> *
> Cross-compiler tool prefix (CROSS_COMPILE) []
> Compile also drivers which will not load (COMPILE_TEST) [N/y/?]y
> 
> 
> I believe we should not do this
> just for unit-testing.

Chopped output will hurt user experience, so I agree it's not a solution
to eliminate trailing whitespace in predefined stdout files for pytest.

Thank you,
Eugeniu.


More information about the U-Boot mailing list