[U-Boot] [PATCH] ARM: socfpga: Put stack at the end of SRAM

Simon Goldschmidt sgoldschmidt at de.pepperl-fuchs.com
Mon May 14 08:03:09 UTC 2018


On 12.05.2018 22:27, Marek Vasut wrote:
> The global data are in the .data section, so there's no point in
> reserving any space for it above stack. Put stack at the end of
> SRAM.
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Chin Liang See <chin.liang.see at intel.com>
> Cc: Dinh Nguyen <dinguyen at kernel.org>
> ---
>   include/configs/socfpga_common.h | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/configs/socfpga_common.h b/include/configs/socfpga_common.h
> index 4de2aa7929..cb67d539b1 100644
> --- a/include/configs/socfpga_common.h
> +++ b/include/configs/socfpga_common.h
> @@ -35,10 +35,8 @@
>   #define CONFIG_SYS_INIT_RAM_ADDR	0xFFE00000
>   #define CONFIG_SYS_INIT_RAM_SIZE	0x40000 /* 256KB */
>   #endif
> -#define CONFIG_SYS_INIT_SP_OFFSET		\
> -	(CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE)
>   #define CONFIG_SYS_INIT_SP_ADDR			\
> -	(CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)
> +	(CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_RAM_SIZE)

I think this interferes with the bootcount being stored at the end of 
SRAM. See the defconfigs of 'is1' and 'sr1500' boards - or my local 
defconfig here :-)

I'd really like to keep some room here for bootcounter and some related 
things I store here.


Simon

>   
>   #define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
>   
> 


More information about the U-Boot mailing list