[U-Boot] [PATCH v1 06/11] spi: stm32_qspi: Update mode management

Patrice CHOTARD patrice.chotard at st.com
Mon May 14 13:24:58 UTC 2018


Hi Jagan

On 05/01/2018 07:31 AM, Jagan Teki wrote:
> On Thu, Apr 26, 2018 at 8:35 PM, Patrice Chotard <patrice.chotard at st.com> wrote:
>> From: Christophe Kerello <christophe.kerello at st.com>
>>
>> We face issue on Macronix/Spansion spi nors due to bad mode management.
>> We solve these issues using following mode configurations:
>>   - read_cmd = CMD_READ_QUAD_OUTPUT_FAST => 1-1-4
>>   - read_cmd = CMD_READ_DUAL_OUTPUT_FAST => 1-1-2
>>   - write_cmd = CMD_QUAD_PAGE_PROGRAM => 1-1-4
>>   - others commands => 1-1-1
>>
>> Signed-off-by: Christophe Kerello <christophe.kerello at st.com>
>> Signed-off-by: Patrice Chotard <patrice.chotard at st.com>
>> ---
>>
>>   drivers/spi/stm32_qspi.c | 30 ++++++++++++++++++------------
>>   1 file changed, 18 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/spi/stm32_qspi.c b/drivers/spi/stm32_qspi.c
>> index 6b7232905bc8..46915194f034 100644
>> --- a/drivers/spi/stm32_qspi.c
>> +++ b/drivers/spi/stm32_qspi.c
>> @@ -156,6 +156,10 @@ enum STM32_QSPI_CCR_FMODE {
>>   /* default SCK frequency, unit: HZ */
>>   #define STM32_QSPI_DEFAULT_SCK_FREQ 108000000
>>
>> +#define STM32_CMD_READ_DUAL_OUTPUT_FAST        0x3b
>> +#define STM32_CMD_READ_QUAD_OUTPUT_FAST        0x6b
>> +#define STM32_CMD_QUAD_PP              0x32
> 
> NAK, pls don't add flash changes in spi.

I will resent this series without this patch.
This patch will be reworked and resubmitted separately.

Thanks

> 
> Jagan.
> 


More information about the U-Boot mailing list