[U-Boot] [PATCH 2/2] PCI: autoconfig: Don't allocate 64-bit addresses to 32-bit only resources

Simon Glass sjg at chromium.org
Mon May 14 19:53:46 UTC 2018


Hi Tuomas,

On 14 May 2018 at 10:38, Tuomas Tynkkynen <tuomas.tynkkynen at iki.fi> wrote:
> Currently, if we happen to allocate an address requiring 64 bits to a
> device only supporting 32-bit BARs, the address eventually gets silently
> truncated to 32 bits. Avoid this by adding a new flag to
> pciauto_region_allocate() to bail out in such situations.
>
> Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen at iki.fi>
> ---
>  drivers/pci/pci_auto.c        | 6 ++++--
>  drivers/pci/pci_auto_common.c | 7 ++++++-
>  drivers/pci/pci_auto_old.c    | 5 +++--
>  include/pci.h                 | 2 +-
>  4 files changed, 14 insertions(+), 6 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

Please can you add a function comment to pciauto_region_allocate()?

Regards,
Simon


More information about the U-Boot mailing list