[U-Boot] [PATCH] tools: adopt --std=gnu99 where C99 comments are needed

[Tom Rini]

On Mon, May 14, 2018 at 02:07:27PM +0200, Dr. Philipp Tomsich wrote:

> While it’s not directly related to this patch, we should clearly state that
> the U-Boot code base (with the possible exception of the tools/ directory,
> which I have started touching here) has _implicitly_ moved to GNU11 
> (yes, even newer than C99), when be upgraded beyond GCC 5.
> 
> For reference, see the "Default standard is now GNU11” section at 
> 	https://gcc.gnu.org/gcc-5/porting_to.html
> 
> Do we want to
> (a)	document this somewhere (which file in doc/ would be appropriate?)
> (b)	explicitly set the “--std=“ flag to make sure that people (and their compilers)
> 	are aware of this?

For the record, I don't see anything here as a problem.  I did half
suggest, and did reviewed-by just spelling out GNU11.  So long as that
isn't a problem for clang-5, I don't think this is a problem.  The "$X
is a warning" are things we've had to long since clean up.  This is also
not me suggesting that we make use of any particular new language
features.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180514/3a7e8dee/attachment.sig>