[U-Boot] [PATCH v2 2/2] video: dw_hdmi: fix HSYNC and VSYNC polarity settings

Jernej Škrabec jernej.skrabec at siol.net
Tue May 15 05:15:30 UTC 2018


Hi,

Dne ponedeljek, 14. maj 2018 ob 22:49:53 CEST je Vasily Khoruzhick napisal(a):
> Currently dw_hdmi configures HSYNC polarity using VSYNC setting from
> EDID and vice versa. Fix it, since it breaks displays where HSYNC
> and VSYNC polarity differs
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul at gmail.com>

Reviewed-by: Jernej Skrabec <jernej.skrabec at siol.net>

Best regards,
Jernej

> ---
>  drivers/video/dw_hdmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/dw_hdmi.c b/drivers/video/dw_hdmi.c
> index dbad0e2b24..229bd63c97 100644
> --- a/drivers/video/dw_hdmi.c
> +++ b/drivers/video/dw_hdmi.c
> @@ -401,11 +401,11 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi,
>  	/* set up hdmi_fc_invidconf */
>  	inv_val = HDMI_FC_INVIDCONF_HDCP_KEEPOUT_INACTIVE;
> 
> -	inv_val |= (edid->flags & DISPLAY_FLAGS_HSYNC_HIGH ?
> +	inv_val |= (edid->flags & DISPLAY_FLAGS_VSYNC_HIGH ?
>  		   HDMI_FC_INVIDCONF_VSYNC_IN_POLARITY_ACTIVE_HIGH :
>  		   HDMI_FC_INVIDCONF_VSYNC_IN_POLARITY_ACTIVE_LOW);
> 
> -	inv_val |= (edid->flags & DISPLAY_FLAGS_VSYNC_HIGH ?
> +	inv_val |= (edid->flags & DISPLAY_FLAGS_HSYNC_HIGH ?
>  		   HDMI_FC_INVIDCONF_HSYNC_IN_POLARITY_ACTIVE_HIGH :
>  		   HDMI_FC_INVIDCONF_HSYNC_IN_POLARITY_ACTIVE_LOW);
> 
> --
> 2.17.0






More information about the U-Boot mailing list