[U-Boot] [PATCH 1/6] usb: dwc3: Add dwc3_init/remove with DM_USB

Michal Simek monstr at monstr.eu
Thu May 17 07:40:23 UTC 2018


On 16.5.2018 16:40, Marek Vasut wrote:
> On 05/16/2018 04:26 PM, Michal Simek wrote:
>> From: Mugunthan V N <mugunthanvnm at ti.com>
>>
>> The patch is preparing dwc3 core for enabling DM_USB with peripheral
>> driver with using driver model support.
>> The driver will be bound by the DWC3 wrapper driver based on the
>> dr_mode device tree entry.
>>
>> Signed-off-by: Mugunthan V N <mugunthanvnm at ti.com>
>> (Remove dwc3-omap changes)
>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>> ---
> [...]
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>> index cbe9850a0bda..ad16c9b7c46c 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -712,7 +712,11 @@ struct dwc3 {
>>  	/* device lock */
>>  	spinlock_t		lock;
>>  
>> +#ifndef CONFIG_DM_USB
> 
> Shouldnt this be ifdef __UBOOT__ ?
> 
>>  	struct device		*dev;
>> +#else
>> +	struct udevice		*dev;
>> +#endif

What about this?

#if defined(__UBOOT__) && defined(CONFIG_DM_USB)
	struct udevice		*dev;
#else
	struct device		*dev;
#endif

Thanks,
Michal

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180517/5c6692e3/attachment.sig>


More information about the U-Boot mailing list