[U-Boot] [PATCH v5 10/16] fastboot: Rename public fb_ functions to fastboot_

Simon Glass sjg at chromium.org
Fri May 18 01:38:00 UTC 2018


Hi,

On 17 May 2018 at 09:59, Alex Kiernan <alex.kiernan at gmail.com> wrote:
> Rename fb_mmc_flash_write/fb_mmc_erase/fb_nand_flash_write/fb_nand_erase to
> fastboot_... as they form a public interface
>
> Signed-off-by: Alex Kiernan <alex.kiernan at gmail.com>
> ---
>
> Changes in v5:
> - new
>
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
>  drivers/fastboot/fb_mmc.c       |  6 +++---
>  drivers/fastboot/fb_nand.c      |  6 +++---
>  drivers/usb/gadget/f_fastboot.c | 12 ++++++------
>  include/fb_mmc.h                |  6 +++---
>  include/fb_nand.h               |  6 +++---
>  5 files changed, 18 insertions(+), 18 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

But see below:

> -void fb_nand_flash_write(const char *cmd, void *download_buffer,
> -                        unsigned int download_bytes, char *response);
> -void fb_nand_erase(const char *cmd, char *response);
> +void fastboot_nand_flash_write(const char *cmd, void *download_buffer,
> +                              unsigned int download_bytes, char *response);
> +void fastboot_nand_erase(const char *cmd, char *response);

Need full docbook function comments for these.

Regards,
Simon


More information about the U-Boot mailing list