[U-Boot] [RFC PATCH v2 1/2] usb: fastboot: Convert USB f_fastboot to shared fastboot

[Alex Kiernan]

Hi Sam
On Fri, May 18, 2018 at 7:32 PM Sam Protsenko <semen.protsenko at linaro.org>
wrote:

> On 17 May 2018 at 19:13, Alex Kiernan <alex.kiernan at gmail.com> wrote:
> > Convert USB fastboot code to use shared fastboot protocol.
> >
> > Signed-off-by: Alex Kiernan <alex.kiernan at gmail.com>
> > ---
> >
> > Changes in v2:
> > - remove redundant version.h
> > - use new fastboot_get_bytes_remaining() function
> >
> >  drivers/fastboot/Makefile       |   4 +-
> >  drivers/usb/gadget/f_fastboot.c | 318
+++++-----------------------------------
> >  2 files changed, 37 insertions(+), 285 deletions(-)
> >

> Hi Alex,

> Unfortunately this patch breaks regular fastboot (over USB). At least
> on TI BeagleBoard X15. I tested your patch series using
> https://github.com/akiernan/u-boot.git, on branch us-fastboot-udp-v6
> (hope it contains v2 of this patch). I'm unable to do "fastboot flash"
> or "fastboot oem format" commands after this patch. Below some debug
> output that can help you debug this issue.


Do you remember if you did the 'oem format' after the 'flash' command? If
so, likely it's got out of sync and the 'oem format' was an innocent victim
after the 'flash' failed...

There's definitely a change in the data transfer which looks like it should
be fine, but I can imagine I've not got quite right.

> On host side I see:

>      FAILED (remote: unrecognized command)

> On device side next messages appear:

>      ** Unrecognized filesystem type **
>      buffer overflowstatus: -104 ep 'ep1in-bulk' trans: 0
>      command es not recognized.

> I'd appreciate if you can fix it in next series. Please add me to Cc:
> so that I can test it on my boards and verify if it's work.

> Also, as I understand, your github branch contains patches from
> different patch series. If you can split them into corresponding
> branches there, I can test your patch series separately and provide
> tested tag.


I've split off the last two patches, so there's just this series which adds
UDP fastboot in that branch now and has only simple refactorings in the USB
path. If you're able to test just that to see if it works?

-- 
Alex Kiernan