[U-Boot] [PATCH v1 1/5] serial: stm32: Add debug uart support

[Patrice CHOTARD]

Hi Simon

On 05/18/2018 03:37 AM, Simon Glass wrote:
> On 17 May 2018 at 06:50, Patrice Chotard <patrice.chotard at st.com> wrote:
>> From: Patrick Delaunay <patrick.delaunay at st.com>
>>
>> Add support for early debug printf, before the availability of
>> driver model and device tree support.
>>
>> Signed-off-by: Patrick Delaunay <patrick.delaunay at st.com>
>> Signed-off-by: Patrice Chotard <patrice.chotard at st.com>
>> ---
>>
>>   drivers/serial/Kconfig        |   9 ++++
>>   drivers/serial/serial_stm32.c | 105 +++++++++++++++++++++++++++++++++---------
>>   2 files changed, 92 insertions(+), 22 deletions(-)
>>
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> One question below.
> [..]
> 
>> +static inline void _debug_uart_init(void)
>> +{
>> +       fdt_addr_t base = CONFIG_DEBUG_UART_BASE;
>> +       struct stm32_uart_info *uart_info = _debug_uart_info();
>> +
>> +       _stm32_serial_init(base, uart_info);
>> +       _stm32_serial_setbrg(base, uart_info,
>> +                            CONFIG_DEBUG_UART_CLOCK,
>> +                            CONFIG_BAUDRATE);
>> +       printf("DEBUG done\n");
> 
> Do you really want this line?

it's a development debug trace, i will remove it.

Thanks

Patrice

> 
> Regards,
> Simon
>