[U-Boot] [PATCH v3 2/6] board: eets: pdu001: Fix wrong default value in Kconfig
Felix Brack
fb at ltec.ch
Tue May 22 08:07:58 UTC 2018
Hi Eugeniu,
On 19.05.2018 14:13, Eugeniu Rosca wrote:
> After importing linux v4.16-rc1 commit 2c37e08464a8 ("kconfig: Warn if
> choice default is not in choice"), Kconfig complains:
>
> scripts/kconfig/conf --syncconfig Kconfig
> board/eets/pdu001/Kconfig:22:warning: \
> choice default symbol 'PDU001_RUN_LED_RED' \
> is not contained in the choice
>
> This looks to be caused by a typo. Fix it.
Indeed, thanks for the fix!
Please make sure to cc maintainers (me in this case). I do not follow
every post on the list ;-)
>
> Fixes: 85ab0452fefc ("arm: add support for PDU001")
> Signed-off-by: Eugeniu Rosca <erosca at de.adit-jv.com>
> Reviewed-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
>
> v2->v3:
> * No changes.
>
> v1->v2:
> * Added: Reviewed-by: Masahiro Yamada <yamada.masahiro at socionext.com>
>
> board/eets/pdu001/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/eets/pdu001/Kconfig b/board/eets/pdu001/Kconfig
> index f28ba6e7bff2..e64ae28875b1 100644
> --- a/board/eets/pdu001/Kconfig
> +++ b/board/eets/pdu001/Kconfig
> @@ -19,7 +19,7 @@ config SYS_CONFIG_NAME
>
> choice
> prompt "State of Run LED"
> - default PDU001_RUN_LED_RED
> + default RUN_LED_RED
> help
> The PDU001 has a bi-color (red/green) LED labeled 'Run' which
> can be used to indicate the operating state of the board. By
>
Reviewed-by: Felix Brack <fb at ltec.ch>
Tested-by: Felix Brack <fb at ltec.ch>
regards, Felix
More information about the U-Boot
mailing list