[U-Boot] [PATCH v6 17/18] usb: fastboot: Convert USB f_fastboot to shared fastboot

[Sam Protsenko]

On 22 May 2018 at 18:21, Sam Protsenko <semen.protsenko at linaro.org> wrote:
> On 22 May 2018 at 12:23, Alex Kiernan <alex.kiernan at gmail.com> wrote:
>> Convert USB fastboot code to use shared fastboot protocol.
>>
>> Signed-off-by: Alex Kiernan <alex.kiernan at gmail.com>
>> ---
>>
>> Changes in v6:
>> - merged from RFC USB fastboot series
>> - when entering the DATA phase ensure we actually install the correct handler
>> - on completion of DATA call new fastboot_data_complete()
>> - previous changes:
>>   - remove redundant version.h
>>   - use new fastboot_get_bytes_remaining() function
>
> Hi Alex,
>
> I tested this new patch series (v6) on X15 board, and this patch still
> breaks "fastboot oem format". I see next messages.
>
> On host:
>
>     FAILED (remote: unrecognized command)
>
> On device:
>
>     command oem format not recognized.
>
> All other fastboot commands seem to work fine, though. Can you please
> look into it? I can help you with testing on my boards, if you are
> unable to reproduce it. You can prepare GitHub branch for debugging
> and ask me to check that, I will send you the output.
>
> Thanks.

Btw, I looked in my .config, and I see that:

    # CONFIG_FASTBOOT_CMD_OEM_FORMAT is not set

What I think should be done, is in your patch:

    fastboot: Add support for 'oem format' command

make default=y for FASTBOOT_CMD_OEM_FORMAT. Or add that to all boards
that use "fastboot oem format". Not sure what is proper way here, but
defaulting it to "n" (like it's done now) might break a lot of boards.