[U-Boot] [PATCH v1] x86: acpi: Adopt new version of iASL compiler

Bin Meng bmeng.cn at gmail.com
Wed May 23 10:22:56 UTC 2018


Hi Andy,

On Wed, May 23, 2018 at 5:38 PM, Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
> The commit
>
>   f9a88a4c1cd0 ("iASL: Enhance the -tc option (create AML hex file in C)")
>
> in ACPICA project changed a template of the a of variable that is used

a template of the a of variable? Cannot understand this.

> in the generated C-file. Now, instead of hard coded "AmlCode" the
> "%s_aml_code" is in use, where the prefix is a lowered case base name of
> the output file. In our case it will be "dsdt" producing a name as
> "dsdt_aml_code".
>
> The quick solution is to call sed which replaces new name by the old one
> to keep compatibility with old version of iASL.
>
> The long term solution would be to modify code to use the new name
> because it more scalable.

it *is* more scalable.

>
> Cc: Robert Moore <robert.moore at intel.com>
> Cc: Sami Mujawar <sami.mujawar at arm.com>
> Cc: Evan Lloyd <evan.lloyd at arm.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> ---
>  scripts/Makefile.lib | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index f9809ce7ce..b5cf7e5427 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -416,6 +416,7 @@ cmd_acpi_c_asl=         \
>
>  $(obj)/dsdt.c:    $(src)/dsdt.asl
>         $(call cmd,acpi_c_asl)
> +       $(Q)sed -i -e "s,dsdt_aml_code,AmlCode," $@
>
>  # Bzip2
>  # ---------------------------------------------------------------------------
> --

Otherwise,
Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

Regards,
Bin


More information about the U-Boot mailing list