[U-Boot] [PATCH v2 3/4] ata: ahci_mvebu: add scsi support

Stefan Roese sr at denx.de
Thu May 24 15:18:22 UTC 2018


On 24.05.2018 04:13, make at marvell.com wrote:
> From: Ken Ma <make at marvell.com>
> 
> Mvebu AHCI is AHCI driver which uses SCSI under the hood.
> This patch adjusts AHCI setup to support SCSI by creating
> a SCSI device as a child.
> 
> Signed-off-by: Ken Ma <make at marvell.com>
> ---
> 
> Changes in v2: None
> 
>   drivers/ata/ahci_mvebu.c | 17 ++++++++++++++++-
>   1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/ahci_mvebu.c b/drivers/ata/ahci_mvebu.c
> index 97a04d9..9041a72 100644
> --- a/drivers/ata/ahci_mvebu.c
> +++ b/drivers/ata/ahci_mvebu.c
> @@ -19,6 +19,20 @@ __weak int board_ahci_enable(void)
>   	return 0;
>   }
>   
> +static int mvebu_ahci_bind(struct udevice *dev)
> +{
> +	struct udevice *scsi_dev;
> +	int ret;
> +
> +	ret = ahci_bind_scsi(dev, &scsi_dev);
> +	if (ret) {
> +		debug("%s: Failed to bind (err=%d\n)", __func__, ret);
> +		return ret;
> +	}
> +
> +	return 0;
> +}
> +
>   static int mvebu_ahci_probe(struct udevice *dev)
>   {
>   	/*
> @@ -27,7 +41,7 @@ static int mvebu_ahci_probe(struct udevice *dev)
>   	 */
>   	board_ahci_enable();
>   
> -	ahci_init(devfdt_get_addr_ptr(dev));
> +	ahci_probe_scsi(dev, (ulong)devfdt_get_addr_ptr(dev));
>   
>   	return 0;
>   }
> @@ -42,5 +56,6 @@ U_BOOT_DRIVER(ahci_mvebu_drv) = {
>   	.name		= "ahci_mvebu",
>   	.id		= UCLASS_AHCI,
>   	.of_match	= mvebu_ahci_ids,
> +	.bind		= mvebu_ahci_bind,
>   	.probe		= mvebu_ahci_probe,
>   };
> 

Please don't drop the already collected tags here - in this
case the Reviewed-by from Simon.

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan



More information about the U-Boot mailing list