[U-Boot] [PATCH v7 14/18] mmc: Separate "mmc swrite" from fastboot

Simon Glass sjg at chromium.org
Fri May 25 02:41:43 UTC 2018


Hi Alex,

On 24 May 2018 at 07:29, Alex Kiernan <alex.kiernan at gmail.com> wrote:
>
> Introduce CONFIG_IMAGE_SPARSE and CONFIG_CMD_MMC_SWRITE so the "mmc
> swrite" command is separated from the fastboot code.
>
> Move image-sparse from common to lib so it's clear it's library code.
>
> Rename CONFIG_FASTBOOT_FLASH_FILLBUF_SIZE to CONFIG_IMAGE_SPARSE_FILLBUF_SIZE
> and migrate it to Kconfig.
>
> Signed-off-by: Alex Kiernan <alex.kiernan at gmail.com>
> Acked-by: Jassi Brar <jaswinder.singh at linaro.org>
> ---
>
> Changes in v7: None
> Changes in v6: None
> Changes in v5:
> - rename CONFIG_FASTBOOT_FLASH_FILLBUF_SIZE to CONFIG_IMAGE_SPARSE_FILLBUF_SIZE
>   and migrate it to Kconfig.
>
> Changes in v4:
> - new
>
> Changes in v3: None
> Changes in v2: None
>
>  cmd/Kconfig                    |  8 ++++++++
>  cmd/mmc.c                      | 12 ++++++------
>  common/Makefile                |  1 -
>  drivers/fastboot/Kconfig       |  1 +
>  lib/Kconfig                    | 11 +++++++++++
>  lib/Makefile                   |  1 +
>  {common => lib}/image-sparse.c |  6 +-----
>  scripts/config_whitelist.txt   |  1 -
>  8 files changed, 28 insertions(+), 13 deletions(-)
>  rename {common => lib}/image-sparse.c (97%)

Reviewed-by: Simon Glass <sjg at chromium.org>

I'm not 100% sure about moving image-sparce to lib/ but I suppose it is OK.

Regards,
Simon


More information about the U-Boot mailing list