[U-Boot] [PATCH v2 1/5] drivers: Add OSD uclass

Mario Six mario.six at gdsys.cc
Fri May 25 11:25:55 UTC 2018


Hi Simon,

On Wed, May 23, 2018 at 6:33 PM, Simon Glass <sjg at chromium.org> wrote:
> On 23 May 2018 at 06:09, Mario Six <mario.six at gdsys.cc> wrote:
>> Some devices offer a text-based OSD (on-screen display) that can be
>> programmatically controlled (i.e. text displayed on).
>>
>> Add a uclass to support such devices.
>>
>> Signed-off-by: Mario Six <mario.six at gdsys.cc>
>>
>> ---
>>
>> v1 -> v2:
>> * Use singular case for UCLASS_VIDEO_OSD description
>> * Expanded description of video_osd_set_mem with example
>> * Replaced all left-over mentions of pixels with text
>> * Renamed x and y parameters to col and row
>> * Expaneded description of color parameter
>> * Added general description of the OSD uclass
>> * Expanded description of video_osd_info
>>
>> ---
>>  drivers/video/Kconfig            |   8 ++
>>  drivers/video/Makefile           |   2 +
>>  drivers/video/video_osd-uclass.c |  46 ++++++++++
>>  include/dm/uclass-id.h           |   1 +
>>  include/video_osd.h              | 193 +++++++++++++++++++++++++++++++++++++++
>>  5 files changed, 250 insertions(+)
>>  create mode 100644 drivers/video/video_osd-uclass.c
>>  create mode 100644 include/video_osd.h
>
> Why drop the 'u' on 'colour'?
>

# git grep color | wc -l
794

# git grep colour | wc -l
191

;-)

> Reviewed-by: Simon Glass <sjg at chromium.org>
>

Best regards,
Mario


More information about the U-Boot mailing list