[U-Boot] [PATCH v1 1/2] buildman: Extract environment as part of each build

[Simon Glass]

Hi Alex,

On 25 May 2018 at 23:19, Alex Kiernan <alex.kiernan at gmail.com> wrote:
> On Sat, May 26, 2018 at 3:07 AM Simon Glass <sjg at chromium.org> wrote:
>
>> Hi Alex,
>
>> On 24 May 2018 at 22:57, Alex Kiernan <alex.kiernan at gmail.com> wrote:
>> > As we're building the boards, extract the default U-Boot environment to
>> > uboot.env so we can interrogate it later.
>> >
>> > Signed-off-by: Alex Kiernan <alex.kiernan at gmail.com>
>> > ---
>> >
>> >  tools/buildman/builderthread.py | 10 ++++++++++
>> >  1 file changed, 10 insertions(+)
>
>> I wonder if this should be an option? Is the file large?
>
>
> Only as big as the things that are defined - it's not the full size of
> CONFIG_ENV_SIZE. The biggest one I've got sitting around is just under 6k,
> which for that particular board is about 2.5% of the disk use for the whole
> result directory - doesn't feel like a huge increase.

OK that sounds fine to me.

>
>> Also please update the README to mention this.
>
>
> Will do.
>
> --
> Alex Kiernan

Regards,
Simon