[U-Boot] [PATCH v3 2/3] misc: uclass: Add enable/disable function

Mario Six mario.six at gdsys.cc
Mon May 28 12:50:22 UTC 2018


Hi Simon,

On Fri, May 25, 2018 at 4:41 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Mario,
>
> On 23 May 2018 at 08:07, Mario Six <mario.six at gdsys.cc> wrote:
>> Add generic enable/disable function to the misc uclass.
>>
>> Signed-off-by: Mario Six <mario.six at gdsys.cc>
>>
>> ---
>>
>> v2 -> v3:
>> * Now return old state from misc_set_enabled
>>
>> v1 -> v2:
>> * Merged the two functions into one function
>> * Explained the semantics of enabling/disabling more throughly
>>
>> ---
>>  drivers/misc/misc-uclass.c | 10 ++++++++++
>>  include/misc.h             | 27 +++++++++++++++++++++++++++
>>  2 files changed, 37 insertions(+)
>>
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> Can you please add a simple dm test for the misc device? Or if
> drivers/mailbox/sandbox-mbox-test.c is sufficient, update it?
>

OK, will add some tests in v4.

> Regards,
> Simon

Best regards,
Mario


More information about the U-Boot mailing list