[U-Boot] [U-Boot,v2,4/7] mach-snapdragon: Fix UART clock flow

Ramon Fried ramon.fried at gmail.com
Mon May 28 19:37:16 UTC 2018


On Mon, May 28, 2018 at 10:35 PM, Tom Rini <trini at konsulko.com> wrote:
> On Mon, May 28, 2018 at 10:28:51PM +0300, Ramon Fried wrote:
>> On Mon, May 28, 2018 at 10:26 PM, Tom Rini <trini at konsulko.com> wrote:
>> > On Mon, May 28, 2018 at 10:24:36PM +0300, Ramon Fried wrote:
>> >> On Mon, May 28, 2018 at 10:19 PM, Jorge Ramirez-Ortiz
>> >> <jramirez at baylibre.com> wrote:
>> >> > On 05/28/2018 09:12 PM, Tom Rini wrote:
>> >> >>
>> >> >> On Wed, May 16, 2018 at 12:13:39PM +0300, Ramon Fried wrote:
>> >> >>
>> >> >>> UART clock enabling flow was wrong.
>> >> >>> Changed the flow according to downstream implementation in LK.
>> >> >>>
>> >> >>> Signed-off-by: Ramon Fried <ramon.fried at gmail.com>
>> >> >>
>> >> >> Applied to u-boot/master, thanks!
>> >> >>
>> >> >
>> >> > Ramon, did you re-test this one on the 820 as we discussed?
>> >> > Sorry Tom, when I tested this on Friday it broke my 820 (I should have
>> >> > reported it to the ML).
>> >> >
>> >> > I think it introduces a regression but I'll let Ramon to confirm.
>> >> Hi.
>> >> It's funny, I'm debugging it now. don't have any conclusions yet but I
>> >> was under the assumption that it won't get merged as it was
>> >> missing Reviewed-by.
>> >> Let me get back to you on these one in couple of hours.
>> >
>> > Yeah, sorry guys, I didn't see anything in public about problems so I
>> > fixed up the one new warning.  Please let me know if you need me to
>> > revert these or if it's an "easy" fix, thanks!
>> Sure.
>> I'll keep you posted. but without any doubt, the following patch is
>> necessary to make it work:
>> https://patchwork.ozlabs.org/patch/921407/
>> Can you please merge it as well ?
>
> 0x0800 is still pretty small.  We're talking about (and oops, I think I
> need to for v2018.07..) bump it to 0x2000 for all TI platforms.  Can you
> v2 doing that size if it works for you (it ought...) and as a default
> VAL if ARCH_SNAPDRAGON ?  Thanks!
Sure. I'll test and resend.
>
> --
> Tom


More information about the U-Boot mailing list