[U-Boot] [PATCH v3 0/6] Iotrace improvements
Simon Glass
sjg at chromium.org
Wed May 30 19:18:17 UTC 2018
Hi Ramon,
On 28 May 2018 at 05:03, Ramon Fried <ramon.fried at gmail.com> wrote:
> These set of patches add few improvements to iotrace.
> * Region limiting - allows setting an address and size where only
> io operations that falls into that address are
> logged.
> * Timestamping - Timestamp every iotrace record with current timestamp
> * dumping - iotrace dump command for dumping all records from buffer
> in a readable fashion.
>
> In terms of backwards compatibility, the timestamp is not backward
> compatible as it changes the iotrace record. so if one developed an
> offline parsing tool it will be broken.
> I though of adding #ifdef specific for that, but eventually I didn't.
>
> v2:
> * fixed printf format
> * added a fix when the buffer is full
> v3:
> * changed the "buffer full" scenario as
> recommended by Simon Glass.
> This fix is dependand on a sperate patch that introduces
> WARN_ONCE definition in bug.h (https://patchwork.ozlabs.org/patch/921391/)
>
> Ramon Fried (6):
> cmd: iotrace: add set region command
> iotrace: add IO region limit
> common: iotrace: add timestamp to iotrace records
> iotrace: move record definitons to header file
> cmd: iotrace: add dump trace command
> iotrace: fix behaviour when buffer is full
>
> cmd/iotrace.c | 63 ++++++++++++++++++++++++++++++++++++++++++---
> common/iotrace.c | 65 +++++++++++++++++++++++++++--------------------
> include/iotrace.h | 57 +++++++++++++++++++++++++++++++++++++++--
> 3 files changed, 153 insertions(+), 32 deletions(-)
It looks like your patch series is a bit broken as the version number
doesn't appear on the patches (e.g. 1/6), only on this cover letter.
Can you fix that? You can use patman which will do all this automatically.
Regards,
Simon
More information about the U-Boot
mailing list