[U-Boot] [ANN] U-Boot v2018.11 delayed a day

[Jagan Teki]

On Tue, Nov 13, 2018 at 4:53 PM Marek Vasut <marek.vasut at gmail.com> wrote:
>
> On 11/13/2018 12:15 PM, Jagan Teki wrote:
> > On Tue, Nov 13, 2018 at 4:33 PM Marek Vasut <marek.vasut at gmail.com> wrote:
> >>
> >> On 11/13/2018 11:54 AM, Boris Brezillon wrote:
> >>> On Tue, 13 Nov 2018 11:41:48 +0100
> >>> Marek Vasut <marek.vasut at gmail.com> wrote:
> >>>
> >>>> On 11/13/2018 11:33 AM, Miquel Raynal wrote:
> >>>>> Hi Marek,
> >>>>>
> >>>>> +Jagan
> >>>>>
> >>>>> Marek Vasut <marek.vasut at gmail.com> wrote on Tue, 13 Nov 2018 03:12:49
> >>>>> +0100:
> >>>>>
> >>>>>> On 11/13/2018 02:12 AM, Tom Rini wrote:
> >>>>>>> On Tue, Nov 13, 2018 at 01:03:41AM +0100, Marek Vasut wrote:
> >>>>>>>> On 11/12/2018 11:25 PM, Tom Rini wrote:
> >>>>>>>>> On Mon, Nov 12, 2018 at 11:13:29PM +0100, Marek Vasut wrote:
> >>>>>>>>>> On 11/12/2018 10:40 PM, Tom Rini wrote:
> >>>>>>>>>>> Hey all,
> >>>>>>>>>>>
> >>>>>>>>>>> Since Jagan promise a v2 SPI PR for some build fixes that we should have
> >>>>>>>>>>> in the release and I believe didn't get them out before the end of his
> >>>>>>>>>>> day, I'm letting everyone know now to expect the release tomorrow
> >>>>>>>>>>> instead, thanks!
> >>>>>>>>>>
> >>>>>>>>>> Will anyone have any chance to test those fixes to verify they didn't
> >>>>>>>>>> break anything ?
> >>>>>>>>>
> >>>>>>>>> Since they're obvious enough by inspection, I'm not worried about it.
> >>>>>>>>
> >>>>>>>> Which patches are those ?
> >>>>>>>
> >>>>>>> The ones in question?
> >>>>>>
> >>>>>> Yes, is there a list ?
> >>>>>
> >>>>> I think this is the branch:
> >>>>> https://github.com/openedev/u-boot-amarula/commits/v2-WIP5
> >>>>
> >>>> Ugh, patchwork links would be nice.
> >>>
> >>> See here [1].
> >>>
> >>>>
> >>>> But for example
> >>>> https://github.com/openedev/u-boot-amarula/commit/91d8f9979420827942ca1f336df36504bd2c1943
> >>>>
> >>>> is quite inobvious, and I think buggy ...
> >>>>
> >>>>      else if (env_get_f("mtdparts", tmp_parts, sizeof(tmp_parts) != -1))
> >>>>
> >>>> sizeof(tmp_parts) != -1 will always be true.
> >>>
> >>> Indeed, I misplaced the closing parens, should be
> >>>
> >>>       else if (env_get_f("mtdparts", tmp_parts, sizeof(tmp_parts)) != -1)
> >>
> >> And the -1 too, even if you move the parenthesis, according to
> >> include/common.h .
> >
> > Travis-ci build fine for all, can we have a fix for this so-that we
> > move accordingly. these fixes are important and need to move for the
> > release.
>
> That patch is buggy and needs to be respun and retested. I don't think
> you can push known buggy patch into a release as a fix.

True, ie what my yesterday plan [1] but this seems to break some know
functionalities in MTD, can't we go with some immediate fix for this?
rest look fine and tested.
Miquel, Boris - Can you test this with fix and send.

[1] https://patchwork.ozlabs.org/patch/995872/