[U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

Andy Shevchenko andy.shevchenko at gmail.com
Thu Nov 15 19:31:36 UTC 2018


On Thu, Nov 15, 2018 at 8:22 PM Alexander Graf <agraf at suse.de> wrote:
> On 15.11.18 18:58, Andy Shevchenko wrote:
> > New callback will give a necessary information to fill up ACPI SPCR table,
> > for example. Maybe used later for other purposes.

> > +/* REVISIT: ACPI GAS specification implied */
>
> What does this REVISIT tag mean?

Had you chance to read my cover letter?
There is a section called "Known issues", item 3 there might answer to
your question.

> > +struct serial_device_info {
> > +     unsigned int baudrate;
> > +     u8      addr_space;     /* 0 - MMIO, 1 - IO */
> > +     u8      reg_width;
> > +     u8      reg_offset;
> > +     u8      reg_shift;
> > +     u64     addr;
> > +};

--
With Best Regards,
Andy Shevchenko


More information about the U-Boot mailing list