[U-Boot] [PATCH v2 1/5] serial: Introduce ->getinfo() callback

[Alexander Graf]

On 15.11.18 20:31, Andy Shevchenko wrote:
> On Thu, Nov 15, 2018 at 8:22 PM Alexander Graf <agraf at suse.de> wrote:
>> On 15.11.18 18:58, Andy Shevchenko wrote:
>>> New callback will give a necessary information to fill up ACPI SPCR table,
>>> for example. Maybe used later for other purposes.
> 
>>> +/* REVISIT: ACPI GAS specification implied */
>>
>> What does this REVISIT tag mean?
> 
> Had you chance to read my cover letter?
> There is a section called "Known issues", item 3 there might answer to
> your question.

The usual tag for "not finalized, please don't apply yet" in upstream
patch submissions is "RFC". If you don't think your code is ready to be
applied, just tag the patches with RFC, like this:

  [RFC] serial: Introduce ->getinfo() callback

Then everyone knows that you don't think the patch is good enough yet.
Otherwise, every submission really implies that you think it should get
applied.

As for the data structure itself, I think I gave you a bit of feedback.
I wouldn't worry too much about getting everything right from the start,
as this is a monolithic open source project. So changing the structure
later on is easy.


Alex