[U-Boot] [PATCH v2 2/5] serial: ns16550: Read reg-io-width from device tree
Andy Shevchenko
andy.shevchenko at gmail.com
Thu Nov 15 19:33:54 UTC 2018
On Thu, Nov 15, 2018 at 8:28 PM Alexander Graf <agraf at suse.de> wrote:
> On 15.11.18 18:58, Andy Shevchenko wrote:
> > Cache the value of the reg-io-width property for the future use.
> > struct ns16550_platdata {
> > unsigned long base;
> > + int reg_width;
> > int reg_shift;
> > - int clock;
> > int reg_offset;
> > + int clock;
>
> Why move clock?
To group reg_* parameters together as it might make sense in the
future to have some other struct which would be used inside
serial_device_info and here.
If it's a big deal, don't pay attention to it, I would not touch it by request.
P.S. Why to overquoute?
--
With Best Regards,
Andy Shevchenko
More information about the U-Boot
mailing list